Skip to content

feat(tui): add config key support to provider create/update forms#1

Open
letv1nnn wants to merge 5 commits into
mainfrom
tui-provider-config-keys-creation
Open

feat(tui): add config key support to provider create/update forms#1
letv1nnn wants to merge 5 commits into
mainfrom
tui-provider-config-keys-creation

Conversation

@letv1nnn

@letv1nnn letv1nnn commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

Add config key (config map) support to the TUI's Create Provider and Update Provider forms.

Previously, both forms only handled credentials and hardcoded config: HashMap::default(), making it impossible to set provider config keys like ANTHROPIC_BASE_URL or OPENAI_BASE_URL via openshell term. The CLI's --config KEY=VALUE flag worked correctly, only the TUI surface was affected.

Related Issue

NVIDIA#1798

Changes

  • Create Provider form: Added config key/value input section with Tab-based navigation between key and
    value fields, auto-commit on Tab, and Ctrl+D to delete entries
  • Update Provider form: Added config key/value editing with existing config hydrated from the provider
    on form open, preserving config that the user doesn't modify
  • Spawn functions: spawn_create_provider and spawn_update_provider now plumb the form's config map
    into the gRPC request instead of sending empty maps

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Screenshots

You can run cargo run -p openshell-cli -- term to try it out yourself.

Provider Details now lists config keys:

image

Updating Provider Details

image image

letv1nnn added 2 commits July 8, 2026 12:13
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
@letv1nnn letv1nnn closed this Jul 8, 2026
@letv1nnn letv1nnn reopened this Jul 8, 2026
@letv1nnn letv1nnn force-pushed the tui-provider-config-keys-creation branch from 7cc376a to 9b02ea9 Compare July 8, 2026 13:17

@r3v5 r3v5 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @letv1nnn ! I left two comments though.

Overall: Solid fix for a real destructive bug. Config keys now editable in both create and update forms, existing config preserved on update. Good use of IndexMap for insertion-order stability.

Comment thread crates/openshell-tui/src/app.rs Outdated
Comment thread crates/openshell-tui/src/app.rs
letv1nnn added 3 commits July 10, 2026 15:38
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants