feat(tui): add config key support to provider create/update forms#1
Open
letv1nnn wants to merge 5 commits into
Open
feat(tui): add config key support to provider create/update forms#1letv1nnn wants to merge 5 commits into
letv1nnn wants to merge 5 commits into
Conversation
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
7cc376a to
9b02ea9
Compare
r3v5
suggested changes
Jul 9, 2026
r3v5
left a comment
There was a problem hiding this comment.
Great work, @letv1nnn ! I left two comments though.
Overall: Solid fix for a real destructive bug. Config keys now editable in both create and update forms, existing config preserved on update. Good use of IndexMap for insertion-order stability.
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add config key (
configmap) support to the TUI's Create Provider and Update Provider forms.Previously, both forms only handled credentials and hardcoded
config: HashMap::default(), making it impossible to set provider config keys likeANTHROPIC_BASE_URLorOPENAI_BASE_URLviaopenshell term. The CLI's--config KEY=VALUEflag worked correctly, only the TUI surface was affected.Related Issue
NVIDIA#1798
Changes
value fields, auto-commit on Tab, and Ctrl+D to delete entries
on form open, preserving config that the user doesn't modify
spawn_create_providerandspawn_update_providernow plumb the form's config mapinto the gRPC request instead of sending empty maps
Testing
mise run pre-commitpassesChecklist
Screenshots
You can run
cargo run -p openshell-cli -- termto try it out yourself.Provider Details now lists config keys:
Updating Provider Details