Merged
Conversation
asengupta3
reviewed
Apr 21, 2026
|
|
||
| let fiveBlockIntroTrial: StimulusType; | ||
| let fiveBlockIntro: any; | ||
| if (taskStore().taskVersion === 2) { |
Collaborator
There was a problem hiding this comment.
Is there a place where taskVersion is set to 2. Is there a way we manage it automatically?
Collaborator
Author
There was a problem hiding this comment.
It's a url/variant param, so it's either set in the variant doc or passed in through the url if it's being run with the demo link. The plan is to set it to 2 for only the language variants that have translations for the new strings so that we can deploy these changes one language at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few small updates to SDS, adding an instruction screen before the first 5-card matching trial and preventing the user from continuing beyond a practice trial until they get it right.