Skip to content

add Bootstrap 5 support#191

Open
guruofgentoo wants to merge 1 commit into
masterfrom
188-bootstrap-5
Open

add Bootstrap 5 support#191
guruofgentoo wants to merge 1 commit into
masterfrom
188-bootstrap-5

Conversation

@guruofgentoo

@guruofgentoo guruofgentoo commented May 22, 2023

Copy link
Copy Markdown
Member

Switch to Bootstrap 5 by default, add two config keys to make selecting bootstrap version for template support a bit easier.

  • select bootstrap version via KEG_BOOTSTRAP_MAJOR_VERSION config (default 5)
  • select whether bootstrap is used at all via KEG_TEMPLATE_FLAVOR config (default bootstrap)
  • use tomselect for bootstrap 5+, in place of select2 (to remove jQuery dependency)

refs #188

BC BREAK Apps that want to stay on Bootstrap 4 will need to set KEG_BOOTSTRAP_MAJOR_VERSION to 4. Apps could also begin extending the horizontal.html form template instead of horizontal-b4.html, but that change is not required.

- select bootstrap version via KEG_BOOTSTRAP_MAJOR_VERSION config (default 5)
- select whether bootstrap is used at all via KEG_TEMPLATE_FLAVOR config (default bootstrap)
- use tomselect for bootstrap 5+, in place of select2 (to remove jQuery dependency)
refs #188
@codecov

codecov Bot commented May 22, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.17%. Comparing base (aa60cd6) to head (8e47e4c).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          33       33           
  Lines        3840     3840           
=======================================
  Hits         3693     3693           
  Misses        147      147           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rsyring

rsyring commented Aug 7, 2025

Copy link
Copy Markdown
Member

@guruofgentoo any reason this didn't end up getting merged?

@guruofgentoo

Copy link
Copy Markdown
Member Author

IIRC it was just due to the BC break at the time, and then fell off the radar. I had forgotten this was out there. We should bring it in though - it makes dealing with the different Bootstrap versions much more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants