tu/kgsl: Fix patched Turnip for Adreno 830/840#54
Merged
Conversation
07c519b to
9e2f19d
Compare
dbec508 to
3b064f5
Compare
Owner
Author
|
Note The driver built by this PR contains both patched Freedreno & Turnip, no need to install unpatched Turnip again. Build artifacts: https://github.com/lfdevs/mesa-for-android-container/actions/runs/25629402080?pr=54#artifacts The
Tips: When testing If export VK_LOADER_DEBUG=all MESA_DEBUG=1 VK_INSTANCE_LAYERS=VK_LAYER_KHRONOS_validation TU_DEBUG=startup,log,perf,nir FD_RD_DUMP=enable |
This was referenced Apr 28, 2026
3fcfd1d to
b0bb7e4
Compare
b0bb7e4 to
e201189
Compare
Currently, `tu_knl_kgsl_load` explicitly fails with `VK_ERROR_INITIALIZATION_FAILED` if the application enables the `VK_KHR_display` instance extension. This causes applications that blindly enable all available instance extensions (such as `vkcube` or WSI layers) to fail device enumeration completely in environments where KMS/DRM support is compiled alongside KGSL (i.e. when VK_USE_PLATFORM_DISPLAY_KHR is exposed). The proper WSI display fallback behavior (returning 0 displays when the DRM master fd is invalid/missing) is already correctly handled by `wsi_display_init_wsi` and `wsi_GetPhysicalDeviceDisplayPropertiesKHR`. Thus, it is safe and more compliant to drop this aggressive check, allowing Vulkan physical device enumeration to succeed even if the display extension was requested.
e201189 to
817b8dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Turnip driver from the standard release (whose release title doesn't have the turnip- prefix) fails to work on most Adreno GPUs, and the possible error messages are as follows. This PR aims to fix this issue.