Skip to content

Support vendoring - #10

Merged
MonterraByte merged 9 commits into
libcdio:masterfrom
skr4n:vendored
Aug 14, 2026
Merged

Support vendoring#10
MonterraByte merged 9 commits into
libcdio:masterfrom
skr4n:vendored

Conversation

@skr4n

@skr4n skr4n commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add a new feature vendored along with an opt-out env variable LIBCDIO_NO_VENDOR.
    • The default is to use system libraries and fallback to vendored builds if that fails.
  • Use the crate's version metadata to indicate libcdio's version. v3.0.0+2.3.0p2.0.0
    • Make vendored builds to provide this exact version.
    • Make non-vendored builds use this as a lower bound when probing the system.
  • Update the CI to test vendored builds.

Closes #8

@skr4n
skr4n force-pushed the vendored branch 11 times, most recently from 6dd17aa to 220dbc6 Compare August 12, 2026 08:01
MonterraByte
MonterraByte requested changes Aug 12, 2026
View reviewed changes
Comment thread build.rs Outdated
Comment thread build.rs Outdated
Comment thread build.rs Outdated
Comment thread build.rs Outdated
Comment thread build.rs Outdated
Comment thread README.md Outdated
@skr4n
skr4n force-pushed the vendored branch 3 times, most recently from 0fae979 to f5d0918 Compare August 13, 2026 06:09
@skr4n

skr4n commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Also, updated libcdio to 2.4.0.

MonterraByte
MonterraByte requested changes Aug 14, 2026
View reviewed changes

@MonterraByte MonterraByte left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor things left.

Comment thread build.rs Outdated
Comment thread build.rs Outdated
Comment thread build.rs Outdated
Comment thread build.rs Outdated
Comment thread .rustfmt.toml
@MonterraByte
MonterraByte merged commit a04c838 into libcdio:master Aug 14, 2026
5 checks passed
@MonterraByte

MonterraByte commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Thanks!

By the way, would you be interested in moving this repo into the libcdio org?

@skr4n

skr4n commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thanks!

By the way, would you be interested in moving this repo into the libcdio org?

Sure!
I've notified the org owner.

@skr4n
skr4n deleted the vendored branch August 14, 2026 10:48
@skr4n

skr4n commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Thanks!
By the way, would you be interested in moving this repo into the libcdio org?

Sure! I've notified the org owner.

You've been invited to the libcdio org and may move the repository.

@MonterraByte

MonterraByte commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

Repo has been moved.

It would probably be a good idea to share access to the crates.io package. Which account(s) should I add to the owners list?

@skr4n

skr4n commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

You may add me and rocky, the author of libcdio.

@MonterraByte

MonterraByte commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

I've added you. Couldn't add Rocky since they haven't linked their GitHub account to crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MonterraByte MonterraByte MonterraByte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add static feature

2 participants

@skr4n @MonterraByte