Skip to content

Refactor: Use links, Error types and group code - #9

Merged
MonterraByte merged 3 commits into
libcdio:masterfrom
skr4n:refactor
Aug 12, 2026
Merged

Refactor: Use links, Error types and group code#9
MonterraByte merged 3 commits into
libcdio:masterfrom
skr4n:refactor

Conversation

@skr4n

@skr4n skr4n commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
  1. The links key allows for Cargo to ensure that there is at most one crate that links to a given native library, preventing duplicate symbols in any given build configuration, which might arise from two different dependencies attempting to link to the same native library.
  2. Return Errors rather than panic/exit.
  3. Move binding generation code into a function.

skr4n added 2 commits August 7, 2026 11:20
The `links` key allows for Cargo to ensure that there is at most one
crate that links to a given native library, preventing duplicate
symbols in any given build configuration, which might arise from two different
dependencies attempting to link to the same native library.

Refer: https://doc.rust-lang.org/cargo/reference/build-scripts.html#the-links-manifest-key
@skr4n
skr4n force-pushed the refactor branch 2 times, most recently from 1f2cd05 to 311c7a8 Compare August 8, 2026 11:26
Comment thread Cargo.toml

@MonterraByte MonterraByte left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment thread build.rs Outdated
@MonterraByte
MonterraByte merged commit 3e94cd2 into libcdio:master Aug 12, 2026
2 checks passed
@skr4n
skr4n deleted the refactor branch August 13, 2026 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants