feat(pack): add PackStats and stats_pack for pack file object statistics#138
Merged
Conversation
Implements experiment 3, task 3 from the course assignment: - Add PackStats struct with fields: total, commits, trees, blobs, tags, deltas - Add Pack::stats_pack(path) -> Result<PackStats, GitError> that: - Opens and validates the pack file header via check_header - Iterates all objects using decode_pack_object - Counts each object by type (BaseObject vs delta variants) - Returns Err on missing file or invalid pack magic - Add 4 tests: - test_stats_pack_small_sha1: normal-path on small-sha1.pack (total=19) - test_stats_pack_medium_sha1_has_deltas: normal-path on medium-sha1.pack (35031 objects, 22339 deltas) - test_stats_pack_file_not_found: error-path for nonexistent file - test_stats_pack_invalid_pack_magic: error-path for corrupted pack header
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64aecdc06e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Use the existing lightweight PackStats analyzer for Pack::stats_pack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Background
git-internalcan fully decode pack files (Pack::decode), but lacks a lightweight way to get object type counts (commits, trees, blobs, tags, deltas) without full decompression and delta resolution.This PR adds a read‑only statistics interface that reuses existing parsing logic.
✨ Changes
📦 New
PackStatsstruct (indecode.rs)⚙️ New
Pack::stats_packmethoddecode_pack_objectdeltas)PackStatsor propagateGitError🧪 Tests (4)
test_stats_pack_small_sha1test_stats_pack_medium_sha1_has_deltastest_stats_pack_file_not_foundtest_stats_pack_invalid_pack_magic✅ All tests pass ·
cargo fmt·clippyclean✅ Verification
cargo test --lib internal::pack::decode::🧠 Design
decode_pack_object→ consistency, minimal duplication?→ no panicscommits + trees + blobs + tags + deltas == total(tested)📂 Files changed
src/internal/pack/decode.rs(only)📎 Compatibility
Thanks for reviewing! 🙏