Skip to content

fix(about): make about.py metadata lookup type-checker-proof #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woutervh merged 1 commit into from
Aug 30, 2026
Merged

fix(about): make about.py metadata lookup type-checker-proof #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/autoadd_bindir/about.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,21 @@


try:
msg = importlib.metadata.metadata(PACKAGE)
pkginfo: dict[str, str | list[str]] = msg.json # type: ignore[attr-defined]
_msg = importlib.metadata.metadata(PACKAGE)
# Materialise a plain ``dict`` so downstream ``.get(...)`` calls are typed
# unambiguously on every supported Python: ``PackageMetadata`` only guarantees
# ``__iter__`` (over keys) and ``__getitem__`` across versions.
pkginfo: dict[str, str] = {key: _msg[key] for key in _msg}
except ValueError: # pragma: no cover
# A distribution name is required. __package__ is None
# A distribution name is required. __package__ is None.
pkginfo = {}
except importlib.metadata.PackageNotFoundError: # pragma: no cover
# fallback if this package is not properly installed
pkginfo = {}


authors: str | list[str] = pkginfo.get("author_email", "unknown")
authors: str = pkginfo.get("Author-email", "unknown")

license_: str | list[str] = pkginfo.get("license_expression") or pkginfo.get("license", "unknown") or "unknown"
license_: str = pkginfo.get("License-Expression") or pkginfo.get("License", "unknown") or "unknown"

version: str = pkginfo.get("version", "unknown") # type: ignore[assignment]
version: str = pkginfo.get("Version", "unknown")