feat: enable pagination for query result previews - #933
Open
DevvoLazza wants to merge 1 commit into
Open
DevvoLazza wants to merge 1 commit into
DevvoLazza wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Hi, I won’t be able to work on this today or tomorrow as I’m away from home. As soon as I’m back, I’ll continue and finish the remaining fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sidebar previews currently put
LIMIT 50(orTOP/FETCH) in the editor, so the existing pagination treats the preview as a user-written hard bound and stops at 50 rows. Send the preview size as an execution option instead, allowing subsequent batches to append in both standalone Studio and StudioWorkspace.This implements the maintainer's scoped design in #816: manual Load More remains; automatic infinite scrolling is deferred.
Type of Change
Related Issue
Closes #816
Changes Made
supportsResultPaginationfor every provider, with matching documentation and integration assertions; hide paging for providers that cannot apply an offset. APIhasMorerequires an automatically applied limit.Testing
Tested locally
Added/updated regression tests, including failing cases before the fixes
All executed tests pass
Full isolated suite: 546 files passed, 17,603 tests passed, 71 skipped, zero failures. Twelve Helm files were not run because Helm is unavailable.
Targeted verification: 553 tests passed. Real SQLite preparation/execution covers disjoint 50 + 50 + 21 pages, preview dispatch, final-page detection, hard bounds, double clicks, failure/retry, cancellation and stale responses in both execution hooks. All 17 provider integration files also pass.
Format, lint, typecheck, knip, README, chart, channel-showcase and security checks pass; lint reports 240 existing warnings and zero errors. Production app build, library build and packed-tarball
attwchecks pass.Browser proof against an isolated production server: sidebar 50 -> 100 -> 121; failed-page retry retains existing rows; explicit LIMIT 50 stays final; mobile controls fit at 390 x 844; ordered query loads 500 + 121 and displays the final row 621.
Modified/new source: 13,163/13,163 measured lines covered. Global local coverage is 57,944/57,949 (99.99%): only unchanged
src/instrumentation.ts:32-36are uncovered because the failure-path test requires POSIX non-root permissions and skips Windows. The required 100% gate needs Linux CI confirmation.Test Environment
Checklist