fix(profiler): render column type icons dynamically based on column type - #935
De-pitcher wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thank you for this, and I am sorry to be closing it. The issue was already assigned when you picked it up, and I had asked you to wait for #888, so that is where it is being finished. The decision is about the assignment and not about your work. Measured against the payload a SQL engine really returns, both branches leave the icon unchanged, so this was never one patch beating the other. Two things of yours are better than what I am taking forward, and I am not losing them. Your type map covers The red check was not your code, it is the chart guard firing because the branch is behind main. The good first issue list still has unassigned items. Tell me which one you want and I will assign it before you start. |
Description
Fixes an issue where the Data Profiler rendered a hardcoded \Hash\ icon for every column regardless of type.
Closes Data Profiler shows the numeric icon on every column regardless of type #880