Return the total amount of data volume used #608
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
|
@berrnd im sorry, this was not intentional. i deleted the dev branch as it was confusing, this had the consequence that it deleted/closed all PRs in this branch. |
Collaborator
|
@berrnd could you please resubmit if you have the time? i tried to recover the changes but you had already deleted your fork |
Author
Didn't know that, without any further hint in the event timeline here this IMHO isn't very well thought out from GitHub - then sorry for my reaction, it just looked like that to me at first.
Restored my fork and resubmitted this PR: => #627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and first thanks a lot for LibreSpeed!
I wanted to show how much data volume the upload / download test used. So I've added 2 properties to the
speedtest_worker.jsstatus data object:dlBytes: Total number of bytes downloadedulBytes: Total number of bytes uploadedThis also includes data during
dlGraceTime/ulGraceTime.Could look like that (a live example is available here):
firefox_2024-04-03_20-11-11.mp4