Skip to content

fix: restrict maxHeight for routes expansion#674

Open
effie-ms wants to merge 4 commits intomainfrom
fix-routes-height
Open

fix: restrict maxHeight for routes expansion#674
effie-ms wants to merge 4 commits intomainfrom
fix-routes-height

Conversation

@effie-ms
Copy link
Contributor

@effie-ms effie-ms commented Mar 18, 2026

Which Linear task is linked to this PR?

https://linear.app/lifi-linear/issue/EMB-314/fix-routes-height-on-main-page

Why was it implemented this way?

Routes container: applying "long-list" className is not possible since the container is outside of the AppContainer.
Playground: maxHeight restriction was removed from the widget container for the new fit-content default. This allows seeing the widget (views without long lists) in full content height - see e.g. "Compact" variant. Also, all the layouts are now centered (not top aligned).

Visual showcase (Screenshots or Videos)

Before and after (routes):
https://github.com/user-attachments/assets/68f1d761-ffde-470d-b8c8-48df376a0526

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.

@effie-ms effie-ms self-assigned this Mar 18, 2026
@github-actions
Copy link

Hey! This is your new endpoint: https://bd96f627.widget-fixroutesh.pages.dev

@effie-ms effie-ms requested a review from chybisov March 18, 2026 18:19
@github-actions
Copy link

Hey! This is your new endpoint: https://1bd7f727.widget-fixroutesh.pages.dev

@github-actions
Copy link

Hey! This is your new endpoint: https://8c2548ea.widget-fixroutesh.pages.dev

@github-actions
Copy link

Hey! This is your new endpoint: https://cd1a4604.widget-fixroutesh.pages.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants