Skip to content

fixes #703 replace local.lightapi.net from vite.config.js#704

Merged
stevehu merged 2 commits into
masterfrom
issue703
Jun 9, 2026
Merged

fixes #703 replace local.lightapi.net from vite.config.js#704
stevehu merged 2 commits into
masterfrom
issue703

Conversation

@stevehu

@stevehu stevehu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 9, 2026 20:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates local development defaults to use https://localhost instead of local.lightapi.net, and reduces repetition in the Vite dev-server proxy configuration.

Changes:

  • Add an apiBaseUrl fallback in vite.config.js and use it across all proxy targets.
  • Update the local build example in README.md to use https://localhost.
  • Change the committed .env default VITE_API_BASE_URL to https://localhost.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
vite.config.js Introduces a single apiBaseUrl value (with fallback) used for all dev proxy routes.
README.md Updates the local build instructions to use https://localhost for VITE_API_BASE_URL.
.env Changes the default API base URL value to https://localhost.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .env Outdated
Comment thread README.md
@stevehu

stevehu commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Reviewed PR #704’s latest Copilot comments. Both were valid, and I patched them.

Changes in portal-view:

  • portal-view/.env:5: VITE_API_BASE_URL is now empty instead of https://localhost, so non-local builds won’t bake localhost into browser assets.
  • portal-view/README.md:16: added a note explaining that default builds use same-origin API paths, and local/target-specific builds should set VITE_API_BASE_URL explicitly when needed.

Verification:

  • git diff --check passed.
  • npm run build passed.
  • npm run lint passed.
  • npm run build-prd passed.
  • Scanned dist after build-prd: no https://localhost or local.lightapi.net.

Current uncommitted files on branch issue703: .env and README.md.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@stevehu
stevehu merged commit 7d470b6 into master Jun 9, 2026
1 check passed
@stevehu
stevehu deleted the issue703 branch June 9, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants