Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates local development defaults to use https://localhost instead of local.lightapi.net, and reduces repetition in the Vite dev-server proxy configuration.
Changes:
- Add an
apiBaseUrlfallback invite.config.jsand use it across all proxy targets. - Update the local build example in
README.mdto usehttps://localhost. - Change the committed
.envdefaultVITE_API_BASE_URLtohttps://localhost.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
vite.config.js |
Introduces a single apiBaseUrl value (with fallback) used for all dev proxy routes. |
README.md |
Updates the local build instructions to use https://localhost for VITE_API_BASE_URL. |
.env |
Changes the default API base URL value to https://localhost. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Reviewed PR #704’s latest Copilot comments. Both were valid, and I patched them. Changes in portal-view:
Verification:
Current uncommitted files on branch issue703: .env and README.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.