Fixed a bug in the list where multiple items got a focus#5
Open
KeizerDev wants to merge 1 commit intolightning-js:mainfrom
Open
Fixed a bug in the list where multiple items got a focus#5KeizerDev wants to merge 1 commit intolightning-js:mainfrom
KeizerDev wants to merge 1 commit intolightning-js:mainfrom
Conversation
|
|
Contributor
michielvandergeest
left a comment
michielvandergeest
left a comment
There was a problem hiding this comment.
hey @KeizerDev Sorry for the late reply to this PR 🙈 Thanks a lot for your contribution - much appreciated!
We have just bumped this repository to the latest version of Blits (the version used here was very outdated) and implemented $hasFocus across all the components, replacing many focus and unfocus hooks
We are not seeing this double focus issue now anymore, so these changes may not be necessary anymore. Could you verify on your end as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you hold the right arrow on the list multiple items get in a state of focused. I am not sure if this is the correct fix because it seems like
$hasFocusis a property that belongs to a Blits component.This is what's happening when you hold the right arrow: