Conversation
|
I've assigned @tnull as a reviewer! |
| Ok(()) | ||
| Ok(()) | ||
| } else { | ||
| Err(Error::ChannelClosingFailed) |
There was a problem hiding this comment.
We should always at least log what/why it failed when we return an error.
| /// `UserChannelId` did not match any channel for the counterparty, silently | ||
| /// succeeding without initiating a close. | ||
| #[tokio::test(flavor = "multi_thread", worker_threads = 1)] | ||
| async fn close_unknown_user_channel_id_errors() { |
There was a problem hiding this comment.
I don't think the change is worth a dedicated test case, please drop it.
d66df47 to
0e2b867
Compare
|
Thanks @tnull — applied both nits:
Tip 0e2b867. The earlier macos 1.85 failure was channel_full_cycle_force_close (Unexpected balance state in tests/common/mod.rs:632) after a splice+force-close path this PR does not change; main is green on the same parent (f375e4d). |
Closes lightningdevkit#1084 Previously close_channel and force_close_channel returned Ok(()) when no matching UserChannelId was found for the counterparty, silently succeeding without initiating a close. Now returns Err(ChannelClosingFailed), matching update_channel_config. AI-assisted: generated by Sera (Hermes Agent), verified manually. Tests compile; integration test requires bitcoind/electrs binaries (architecturally incompatible electrs binary in this cron environment, same failure affects all integration tests) Signed-off-by: Bartok9 <259807879+Bartok9@users.noreply.github.com>
…ke — stable+beta green on same SHA)
05d2687 to
2f63c5f
Compare
|
Quick flag: CI is red on this PR (and the same-base #1098 / #1002) because upstream |
3 participants
close_channelandforce_close_channelreturnedOk(())when no matchingUserChannelIdwas found for the counterparty, silently succeeding without initiating a close. Now returnsErr(ChannelClosingFailed), matchingupdate_channel_config.Closes #1084
AI-assisted: generated by Sera (Hermes Agent), verified manually. Integration test compiles; runtime requires bitcoind/electrs binaries not available in this cron environment.
Agent-Owner:sera