Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
benthecarman
force-pushed
the
migrate-forwarded-payments-ldk-node
branch
from
September 14, 2026 18:11
a38f16d to
7625fdc
Compare
tnull
reviewed
Sep 15, 2026
| # Forwarding history: "detailed" retains individual records for the current and previous hour, | ||
| # then aggregates them into hourly channel-pair statistics and removes the individual records. | ||
| # "stats" updates per-channel totals directly without storing individual forwards. | ||
| #forwarded_payment_tracking_mode = "stats" # Default: "stats" |
Collaborator
There was a problem hiding this comment.
Given that this is the default, should we expose channel_stats, list_channel_stats, and list_channel_pair_stats in this PR?
Update the server and end-to-end test dependency pins to include forwarded payment storage. Handle the new node errors and runtime setup result required by the updated API. AI assistance: OpenAI Codex.
Use ldk-node for forwarding history and pagination. Remove the server-specific SQLite database, storage code, and event-driven history writes so all payment history uses the node's store. AI assistance: OpenAI Codex.
benthecarman
force-pushed
the
migrate-forwarded-payments-ldk-node
branch
from
September 16, 2026 18:18
c5b7158 to
42e05f6
Compare
tnull
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162
Closes #172
With lightningdevkit/ldk-node#772 merged we can now use this instead of the original ldk-server based version. This also allows us to remove ldk-server's specific sqlite db and implementation.