Skip to content

LCORE-2547: finish tests/ OGX naming for e2e harness and fixtures - #2662

Open
asimurka wants to merge 1 commit into
lightspeed-core:mainfrom
asimurka:lcore-2547-ogx-e2e-pr3
Open

LCORE-2547: finish tests/ OGX naming for e2e harness and fixtures#2662
asimurka wants to merge 1 commit into
lightspeed-core:mainfrom
asimurka:lcore-2547-ogx-e2e-pr3

Conversation

@asimurka

@asimurka asimurka commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

  • E2e harness: ogx: shields configs, README/prow helper comments
  • Remove obsolete OGX llama-guard shield unregister/register utilities
  • Clean up tests/configuration/ fixtures and stale unit/integration references

Out of scope: tests/e2e-prow/ K8s IDs, deprecated llama_stack alias tests, benchmark blobs.

Type of change

  • Configuration Update
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

  • Assisted-by: Cursor
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue LCORE-2547

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.

Testing

  • uv run pytest tests/unit/client/test_ogx.py tests/integration/test_unified_synthesis.py tests/unit/test_ogx_synthesize.py tests/unit/telemetry/ -q
  • uv run make format

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0fc9404a-6870-4fbc-93be-efa15c265086

📥 Commits

Reviewing files that changed from the base of the PR and between d28db67 and 9cf67de.

📒 Files selected for processing (29)
  • tests/configuration/benchmarks-postgres.yaml
  • tests/configuration/benchmarks-sqlite.yaml
  • tests/configuration/lightspeed-stack-proper-name.yaml
  • tests/configuration/lightspeed-stack.yaml
  • tests/configuration/minimal-stack.yaml
  • tests/configuration/run.yaml
  • tests/e2e/configuration/README.md
  • tests/e2e/configuration/library-mode/lightspeed-stack-shields-empty.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-shields-override-disabled.yaml
  • tests/e2e/configuration/library-mode/lightspeed-stack-shields.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-authorized.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-negative.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-shields-empty.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-shields-override-disabled.yaml
  • tests/e2e/configuration/server-mode/lightspeed-stack-shields.yaml
  • tests/e2e/features/environment.py
  • tests/e2e/features/proxy.feature
  • tests/e2e/features/query.feature
  • tests/e2e/features/steps/README.md
  • tests/e2e/features/steps/shields.py
  • tests/e2e/features/streaming_query.feature
  • tests/e2e/utils/README.md
  • tests/e2e/utils/ogx_config_utils.py
  • tests/e2e/utils/ogx_utils.py
  • tests/e2e/utils/prow_utils.py
  • tests/integration/test_unified_synthesis.py
  • tests/unit/pydantic_ai_lightspeed/llamastack/README.md
  • tests/unit/telemetry/conftest.py
  • tests/unit/test_ogx_synthesize.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@asimurka
asimurka force-pushed the lcore-2547-ogx-e2e-pr3 branch from 29a9f6b to 9cf67de Compare September 11, 2026 12:52
@asimurka

Copy link
Copy Markdown
Contributor Author

/retest

@red-hat-konflux-kflux-prd-rh02

Copy link
Copy Markdown
Contributor

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

@asimurka: No presubmit jobs available for lightspeed-core/lightspeed-stack@main

Details

In response to this:

/retest enterprise-contract

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@asimurka

Copy link
Copy Markdown
Contributor Author

/retest

@red-hat-konflux-kflux-prd-rh02

Copy link
Copy Markdown
Contributor

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

@asimurka

Copy link
Copy Markdown
Contributor Author

/retest enterprise-contract

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

@asimurka: No presubmit jobs available for lightspeed-core/lightspeed-stack@main

Details

In response to this:

/retest enterprise-contract

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@asimurka

Copy link
Copy Markdown
Contributor Author

/retest lightspeed-core-0-8-enterprise-contract

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

@asimurka: No presubmit jobs available for lightspeed-core/lightspeed-stack@main

Details

In response to this:

/retest lightspeed-core-0-8-enterprise-contract

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@asimurka

Copy link
Copy Markdown
Contributor Author

/test

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

@asimurka: No presubmit jobs available for lightspeed-core/lightspeed-stack@main

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant