-
Notifications
You must be signed in to change notification settings - Fork 62
fix(agents): remove non-existent AsyncAgent.initialize() calls #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The AsyncAgent class in llama-stack-client 0.3.5 does not have an initialize() method. These calls were causing AttributeError at runtime. The agent does not require explicit initialization - create_session() works without it. Signed-off-by: Major Hayden <major@redhat.com>
WalkthroughRemoves explicit asynchronous initialization calls ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @major. Thanks for your PR. I'm waiting for a lightspeed-core member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
asimurka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Remove calls to
AsyncAgent.initialize()inget_agent()andget_temp_agent()functions. This method does not exist in llama-stack-client 0.3.5 and causesAttributeErrorat runtime.The agent does not require explicit initialization -
create_session()works without it.Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
get_agent()orget_temp_agent()AttributeError: 'AsyncAgent' object has no attribute 'initialize'is raisedSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.