Allow caching Flysystem resolver lookups - #1663
Open
ousamabenyounes wants to merge 2 commits into
Open
Conversation
Collaborator
|
does wrapping the psr cache resolver around the flysystem resolver not work? https://symfony.com/bundles/LiipImagineBundle/current/cache-resolver/psr_cache.html - the example wraps an S3 resolver, but if i am not mistaken, you can wrap any resolver with the cache resolver |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optional
cacheservice ID to Flysystem resolver configuration. When configured, the factory keeps the Flysystem resolver as the inner service and exposes a PSR-6-cached resolver under the configured resolver name, matching the existing cache-decoration pattern used by the S3 resolver.The Flysystem resolver documentation and 3.x changelog now describe the option.
Test verification (RED → GREEN)
On unmodified
origin/3.xwith the new functional configuration and regression test:With the implementation:
Full local replay compared with
origin/3.x: