feat(sharings): Allow nested folder sharings#4875
Open
taratatach wants to merge 1 commit into
Open
Conversation
Drive roots can now live inside an existing sharing: the blanket parent/descendant rejections in ValidateDriveRoot are replaced by a single effective-access gate. When the AccessResolver finds an applicable additive ancestor scope, write access (POST) is required on it, otherwise the root is rejected with the new ErrParentReadOnly, mapped to 403 in the drives API. Roots without an applicable scope are allowed. New drives are explicitly created with access_mode additive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drive roots can now live inside an existing sharing: the blanket
parent/descendant rejections in ValidateDriveRoot are replaced by a
single effective-access gate. When the AccessResolver finds an
applicable additive ancestor scope, write access (POST) is required
on it, otherwise the root is rejected with the new ErrParentReadOnly,
mapped to 403 in the drives API. Roots without an applicable scope
are allowed. New drives are explicitly created with access_mode
additive.
Closes #4838