Skip to content

Run tests with debug assertions enabled - #1748

Open
LaurenzV wants to merge 3 commits into
mainfrom
laurenz/debug_assert
Open

Run tests with debug assertions enabled#1748
LaurenzV wants to merge 3 commits into
mainfrom
laurenz/debug_assert

Conversation

@LaurenzV

Copy link
Copy Markdown
Collaborator

No description provided.

@LaurenzV

Copy link
Copy Markdown
Collaborator Author

The Windows CI run does take longer in this PR (20 minutes vs. 12 minutes), but looking at the logs this seems to be because the dependency builds are simply not cached. I spot-checked the test runtimes and they look about the same, so I think this should be fine!

@LaurenzV
LaurenzV marked this pull request as ready for review July 15, 2026 07:25
@LaurenzV
LaurenzV requested a review from DJMcNab July 15, 2026 07:27
@grebmeg

grebmeg commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

@DJMcNab what do you think of this?

@DJMcNab

DJMcNab commented Aug 7, 2026

Copy link
Copy Markdown
Member

I don't know. If it's making ci build times that much longer, that seems pretty bad.
But as a thing to want, it seems reasonable enough.

@LaurenzV

LaurenzV commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator Author

The longer build times just seem to be because dependencies aren't cached (yet).

@grebmeg

grebmeg commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

I don't know. If it's making ci build times that much longer, that seems pretty bad.
But as a thing to want, it seems reasonable enough.

Yes, I guess this is unfortunate for the debug assertions checks. Maybe there's a middle ground where some optimizations are enabled while keeping the debug assertions?

The longer build times just seem to be because dependencies aren't cached (yet).

Could we verify that it's being cached by comparing the execution times of consecutive CI checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants