fix d2ClientBuilder shutdown corner case#1052
Open
brycezhongqing wants to merge 1 commit intomasterfrom
Open
Conversation
e4f9a3b to
3de0c00
Compare
bohhyang
reviewed
Apr 9, 2025
| { | ||
| if (executor.isShutdown()) | ||
| { | ||
| LOG.warn("Executor is already shut down"); |
Contributor
There was a problem hiding this comment.
don't need warning, info level is fine.
Collaborator
Author
Sadly. No. As If |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a corner case bug in d2ClientBuilder shutdown logic.
Corner case: when
_config._executorService == nullThen
_executorServicewill be added toexecutorsToShutDown. Finally, when d2Client call the shutdown method, the _executorService may be closed twice. Like