TPT-4573: add group_by parameter to alert definitions for metric aggregation - #852
Open
zliang-akamai wants to merge 1 commit into
Open
TPT-4573: add group_by parameter to alert definitions for metric aggregation#852zliang-akamai wants to merge 1 commit into
zliang-akamai wants to merge 1 commit into
Conversation
zliang-akamai
requested review from
lgarber-akamai,
psnoch-akamai and
yec-akamai
and
a balanced review from Copilot
and removed request for
a team
August 11, 2026 17:32
Contributor
There was a problem hiding this comment.
Pull request overview
Adds group_by support for metric aggregation in alert definitions.
Changes:
- Adds create/update handling for
group_by. - Updates generated documentation and examples.
- Adds integration coverage and updates the SDK dependency.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
plugins/modules/monitor_services_alert_definition.py |
Adds the new module parameter. |
requirements.txt |
Raises the SDK minimum version. |
tests/integration/targets/monitor_services_alert_definition/tasks/main.yaml |
Tests creation and persistence. |
plugins/module_utils/doc_fragments/alert_definition.py |
Updates examples and return sample. |
plugins/module_utils/doc_fragments/alert_definition_info.py |
Updates the info return sample. |
plugins/module_utils/doc_fragments/alert_definitions_list.py |
Updates the list return sample. |
plugins/module_utils/doc_fragments/alert_definitions_by_service_type_list.py |
Updates the service list sample. |
docs/modules/monitor_services_alert_definition.md |
Documents the parameter. |
docs/modules/monitor_services_alert_definition_info.md |
Documents info output. |
docs/modules/monitor_services_alert_definition_list.md |
Documents list output. |
docs/modules/monitor_services_alert_definition_by_service_type_list.md |
Documents service list output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "channel_ids", | ||
| "description", | ||
| "entity_ids", | ||
| "group_by", |
lgarber-akamai
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add
group_byparameter to alert definitions for metric aggregation.✔️ How to Test