chore(chart-deps): update argocd to version 10.3.0 - #3499
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the vendored Argo CD Helm chart dependency to argo-cd 10.3.0 (Argo CD v3.5.0) and refreshes the chart’s vendored assets (values, templates, CRDs, and redis-ha subchart) to match upstream behavior.
Changes:
- Update chart dependency/version metadata to Argo CD chart 10.3.0 (appVersion v3.5.0) and refresh lockfile.
- Sync upstream chart defaults and templates (notably ListenerSet/HTTPRoute behavior and
global.networkPolicy.createdefault). - Update vendored CRDs and redis-ha subchart versions/images and related templates/docs.
Reviewed changes
Copilot reviewed 28 out of 29 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/dependencies.yaml | Bumps argo-cd dependency version to 10.3.0. |
| charts/argocd/values.yaml | Syncs upstream values defaults (networkPolicy default, ListenerSet fields, Redis/exporter tags, metrics config). |
| charts/argocd/templates/crds/crd-appproject.yaml | Updates AppProject CRD schema (adds sourceIntegrity, syncOverrun, deprecations). |
| charts/argocd/templates/crds/crd-applicationset.yaml | Updates ApplicationSet CRD schema (adds fields like tagPrefix, repoURL additions, archived repo flags). |
| charts/argocd/templates/crds/crd-application.yaml | Updates Application CRD schema (adds tagPrefix, hydration repoURL, status fields). |
| charts/argocd/templates/argocd-server/listenerset.yaml | Adds synthesized ListenerSet listener fallback when no explicit listeners are provided. |
| charts/argocd/templates/argocd-server/httproute.yaml | Adds ListenerSet-based default parentRef/hostnames when not explicitly configured. |
| charts/argocd/templates/argocd-notifications/networkpolicy.yaml | Adjusts NetworkPolicy render condition to follow global/notifications networkPolicy flags. |
| charts/argocd/templates/argocd-applicationset/networkpolicy.yaml | Expands ApplicationSet NetworkPolicy condition to include HTTPRoute usage. |
| charts/argocd/templates/argocd-applicationset/listenerset.yaml | Adds synthesized ListenerSet listener fallback for ApplicationSet webhook. |
| charts/argocd/templates/argocd-applicationset/httproute.yaml | Adds ListenerSet-based default parentRef/hostnames for ApplicationSet HTTPRoute. |
| charts/argocd/templates/_helpers.tpl | Adjusts redis name helper for redis-ha without HAProxy. |
| charts/argocd/README.md | Updates docs for ListenerSet synthesis and notes breaking change for network policy default. |
| charts/argocd/charts/redis-ha/values.yaml | Updates redis-ha default values (image tags, HAProxy options, probes, hostname resolution options). |
| charts/argocd/charts/redis-ha/templates/sentinel-auth-secret.yaml | Allows templated sentinel.existingSecret via tpl. |
| charts/argocd/charts/redis-ha/templates/redis-tls-secret.yaml | Allows templated tls.secretName via tpl. |
| charts/argocd/charts/redis-ha/templates/redis-haproxy-service.yaml | Adds service IP-family options and additional HAProxy ports. |
| charts/argocd/charts/redis-ha/templates/redis-haproxy-network-policy.yaml | Fixes include context passed to redis-ports. |
| charts/argocd/charts/redis-ha/templates/redis-haproxy-deployment.yaml | Adds additional container ports and supports templated secret names. |
| charts/argocd/charts/redis-ha/templates/redis-ha-statefulset.yaml | Updates annotations handling, init container security context/resources, secret templating, and split-brain probes. |
| charts/argocd/charts/redis-ha/templates/redis-ha-serviceaccount.yaml | Updates secret references and attempts to dedupe auth secrets. |
| charts/argocd/charts/redis-ha/templates/redis-ha-network-policy.yaml | Fixes include context passed to redis-ports. |
| charts/argocd/charts/redis-ha/templates/redis-auth-secret.yaml | Allows templated existingSecret via tpl. |
| charts/argocd/charts/redis-ha/templates/_configs.tpl | Updates scripts/config generation (hostname resolution, quorum handling, HAProxy timeouts). |
| charts/argocd/charts/redis-ha/README.md | Syncs redis-ha parameter table to new defaults/options. |
| charts/argocd/charts/redis-ha/Chart.yaml | Bumps redis-ha chart version/appVersion. |
| charts/argocd/Chart.yaml | Bumps argo-cd chart version/appVersion and redis-ha dependency version. |
| charts/argocd/Chart.lock | Updates dependency lock for redis-ha. |
| apps.yaml | Updates reported Argo CD appVersion to 3.5.0. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 28 out of 29 changed files in this pull request and generated no new comments.
Suppressed comments (4)
charts/argocd/charts/redis-ha/templates/redis-ha-serviceaccount.yaml:23
- The "single secret" ServiceAccount branch compares the raw
existingSecretandsentinel.existingSecretvalues. Now that these values can be templated viatpl, two different templates that render to the same name will not match and can produce duplicate (identical) entries insecrets:. Compare the rendered values instead.
{{- if and (and (.Values.auth) (.Values.sentinel.auth)) (eq (.Values.existingSecret) (.Values.sentinel.existingSecret)) }}
- name: {{ default (include "redis-ha.fullname" .) (tpl (.Values.existingSecret | default "" ) . ) }}
charts/argocd/templates/argocd-server/listenerset.yaml:28
- The synthesized ListenerSet listener hostname is rendered unquoted. If users set a wildcard hostname (e.g. "*.example.com") or a value containing characters YAML treats specially, the manifest can become invalid. Quote the rendered hostname (similar to the HTTPRoute template).
- name: {{ .Values.server.listenerset.listenerName }}
port: {{ .Values.server.listenerset.port }}
protocol: {{ .Values.server.listenerset.protocol }}
hostname: {{ tpl (.Values.server.listenerset.hostname | default .Values.global.domain) $ }}
{{- if .Values.server.listenerset.tls.enabled }}
charts/argocd/templates/argocd-applicationset/listenerset.yaml:28
- The synthesized ListenerSet listener hostname is rendered unquoted. If users set a wildcard hostname (e.g. "*.example.com") or a value containing characters YAML treats specially, the manifest can become invalid. Quote the rendered hostname (similar to the HTTPRoute template).
- name: {{ .Values.applicationSet.listenerset.listenerName }}
port: {{ .Values.applicationSet.listenerset.port }}
protocol: {{ .Values.applicationSet.listenerset.protocol }}
hostname: {{ tpl (.Values.applicationSet.listenerset.hostname | default .Values.global.domain) $ }}
{{- if .Values.applicationSet.listenerset.tls.enabled }}
charts/argocd/charts/redis-ha/templates/redis-haproxy-service.yaml:30
ipFamiliesis rendered as an inline key withtoYaml | nindent 2, which will indent list items to the same level as the key (ipFamilies:). That produces invalid YAML for a list value. Increase the indentation so list items are nested underipFamilies.
{{- if .Values.haproxy.service.ipFamilies }}
ipFamilies: {{ toYaml .Values.haproxy.service.ipFamilies | nindent 2 }}
{{- end }}
|
Installation works, but seeing reported issue: argoproj/argo-cd#29063 |
merll
left a comment
There was a problem hiding this comment.
Blocking until cause of reported issue (Operation State unknown in list view) is known.
This PR updates the dependency argo-cd to version 10.3.0.