chore(chart-deps): update cloudnative-pg-plugin-barman-cloud to version 0.7.1 - #3501
chore(chart-deps): update cloudnative-pg-plugin-barman-cloud to version 0.7.1#3501svcAPLBot wants to merge 21 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the vendored Helm chart dependency for CloudNativePG’s plugin-barman-cloud to chart version 0.7.1 (appVersion v0.14.0) and syncs the local chart files (values, schema, templates, and docs) accordingly.
Changes:
- Bump
cloudnative-pg-plugin-barman-clouddependency from 0.6.0 → 0.7.1 and update the vendored chart metadata (Chart.yaml/README). - Update chart templates and values to match upstream changes (RBAC API group override, issuer naming helper + optional Issuer creation, probe adjustments, CRD updates).
- Add/refresh documentation sources (
README.md.gotmpl) and update the rendered README.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/dependencies.yaml | Bumps the dependency version for the vendored CNPG plugin chart. |
| charts/cloudnative-pg-plugin-barman-cloud/Chart.yaml | Updates chart version/appVersion to 0.7.1 / v0.14.0. |
| charts/cloudnative-pg-plugin-barman-cloud/values.yaml | Adds/adjusts values for RBAC API group and certificate issuer behavior. |
| charts/cloudnative-pg-plugin-barman-cloud/values.schema.json | Updates the values schema to reflect upstream changes (but currently needs fixes for missing type declarations). |
| charts/cloudnative-pg-plugin-barman-cloud/templates/_helpers.tpl | Adds helper for issuer naming (needs validation when createIssuer=false). |
| charts/cloudnative-pg-plugin-barman-cloud/templates/certificate-issuer.yaml | Makes Issuer creation conditional and switches to the issuer-name helper. |
| charts/cloudnative-pg-plugin-barman-cloud/templates/client-certificate.yaml | Switches issuerRef name to the helper. |
| charts/cloudnative-pg-plugin-barman-cloud/templates/server-certificate.yaml | Switches issuerRef name to the helper. |
| charts/cloudnative-pg-plugin-barman-cloud/templates/rbac.yaml | Makes CNPG API group configurable via values. |
| charts/cloudnative-pg-plugin-barman-cloud/templates/deployment.yaml | Updates probes (and adds liveness probe). |
| charts/cloudnative-pg-plugin-barman-cloud/templates/crds/crds.yaml | Updates CRD generator version and CRD schema fields (e.g., compression enum, restore args). |
| charts/cloudnative-pg-plugin-barman-cloud/test/simple-deployment/01-simple_deployment-assert.yaml | Updates chart test assertions to match probe changes. |
| charts/cloudnative-pg-plugin-barman-cloud/README.md.gotmpl | Adds README template source for doc generation. |
| charts/cloudnative-pg-plugin-barman-cloud/README.md | Updates rendered README content and values table to 0.7.1/v0.14.0. |
Suppressed comments (3)
charts/cloudnative-pg-plugin-barman-cloud/values.schema.json:65
commonAnnotationsin the values schema is missing atypedeclaration, which weakens schema validation and tooling support.
"commonAnnotations": {
"additionalProperties": true,
"description": "Annotations to be added to all other resources.",
"required": []
},
charts/cloudnative-pg-plugin-barman-cloud/values.schema.json:173
imagePullSecretsin the values schema is missing atype: "array", which prevents the schema from properly constraining user input.
"imagePullSecrets": {
"additionalProperties": true,
"items": {
"required": []
},
"required": []
},
charts/cloudnative-pg-plugin-barman-cloud/values.schema.json:317
- The values schema entries for
tolerations,topologySpreadConstraints, andupdateStrategyare missingtypedeclarations. This reduces the effectiveness ofvalues.schema.jsonfor validation and documentation generation.
"tolerations": {
"additionalProperties": true,
"description": "Tolerations for the operator to be installed.",
"items": {
"required": []
| {{- define "plugin-barman-cloud.certificateIssuerName" -}} | ||
| {{- default (printf "%s-selfsigned-issuer" (include "plugin-barman-cloud.fullname" .)) .Values.certificate.issuerName }} | ||
| {{- end }} |
| "additionalArgs": { | ||
| "additionalProperties": true, | ||
| "description": "Additional arguments to be added to the operator's args list.", | ||
| "items": { | ||
| "required": [] |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Suppressed comments (6)
charts/cloudnative-pg-plugin-barman-cloud/templates/_helpers.tpl:79
certificate.createIssuercan disable rendering the Issuer, but the issuer name helper will still default to a selfsigned issuer name whencertificate.issuerNameis empty. That results in Certificates referencing a non-existent Issuer ifcreateIssuer=falseandissuerNameis not set. Fail fast in that configuration by requiringcertificate.issuerName, while keeping the current default behavior whencreateIssuer=true.
{{- default (printf "%s-selfsigned-issuer" (include "plugin-barman-cloud.fullname" .)) .Values.certificate.issuerName }}
charts/cloudnative-pg-plugin-barman-cloud/values.schema.json:246
resourcesinvalues.schema.jsonis missingtype: object, so Helm validation will accept non-object values (e.g. a string) and only fail later at render time. Addtype: objectto ensure early, clear validation.
"resources": {
"additionalProperties": true,
"required": []
},
charts/cloudnative-pg-plugin-barman-cloud/values.schema.json:325
topologySpreadConstraintsandupdateStrategyinvalues.schema.jsonare missingtypedeclarations (arrayandobjectrespectively). Without these, Helm validation becomes permissive and can allow invalid values through. Add explicit types to restore effective validation.
"topologySpreadConstraints": {
"additionalProperties": true,
"description": "Topology Spread Constraints for the operator to be installed.",
"items": {
"required": []
charts/cloudnative-pg-plugin-barman-cloud/test/simple-deployment/01-simple_deployment-assert.yaml:26
- This test fixture asserts readiness/liveness probes on port 8081, but the deployment args and Service in the same fixture still use 9090. Unless the plugin actually opens 8081, this makes the rendered manifest and test inconsistent and will fail deployments. Align the probe ports with the server/service port.
port: 8081
charts/cloudnative-pg-plugin-barman-cloud/values.schema.json:8
values.schema.jsonis missingtypedeclarations for several top-level properties (e.g.additionalArgs,additionalEnv,affinity). Withouttype, JSON Schema keywords likeitemsare ignored for non-arrays and the schema becomes overly permissive. This deviates from the pattern used incharts/cloudnative-pg/values.schema.json(e.g. it definestype: array/object). Add the missingtypefields so Helm validation is effective.
"additionalArgs": {
"additionalProperties": true,
"description": "Additional arguments to be added to the operator's args list.",
"items": {
"required": []
charts/cloudnative-pg-plugin-barman-cloud/values.schema.json:65
commonAnnotationsinvalues.schema.jsonis missingtype: object, which means non-object values can pass Helm values validation unexpectedly. Add an explicit object type to keep schema validation consistent and useful.
This issue also appears in the following locations of the same file:
- line 243
- line 321
"commonAnnotations": {
"additionalProperties": true,
"description": "Annotations to be added to all other resources.",
"required": []
},
| periodSeconds: 10 | ||
| tcpSocket: | ||
| port: 9090 | ||
| port: 8081 |
This PR updates the dependency plugin-barman-cloud to version 0.7.1.
TODO: Update app version in apps.yaml.