chore(chart-deps): update gitea to version 12.7.0 - #3503
Draft
svcAPLBot wants to merge 2 commits into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the vendored Gitea Helm chart to 12.7.0 (Gitea 1.27.0) and carries forward upstream changes, including new Gateway API exposure options and related documentation/templates.
Changes:
- Upgrade Gitea chart dependency to
12.7.0and appVersion to1.27.0. - Add Gateway API support (HTTPRoute/TCPRoute/BackendTLSPolicy + NGINX ClientSettingsPolicy) with values + docs.
- Refactor service naming to helpers and update ingress/route/test templates accordingly.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/gitea/Chart.yaml | Bumps chart/app versions and updates Artifact Hub changelog entries. |
| charts/dependencies.yaml | Updates the pinned gitea chart dependency to 12.7.0. |
| apps.yaml | Updates displayed Gitea appVersion to 1.27.0. |
| charts/gitea/values.yaml | Adds gatewayAPI configuration block and normalizes some YAML formatting. |
| charts/gitea/templates/_helpers.tpl | Extends public hostname/protocol derivation to account for Gateway API HTTPRoute. |
| charts/gitea/templates/tests/test-http-connection.yaml | Updates helm test to target the HTTP service name helper. |
| charts/gitea/templates/gitea/_services.tpl | Introduces helpers for HTTP/SSH Service names. |
| charts/gitea/templates/gitea/httpService.yaml | Switches to the HTTP Service name helper and reorders metadata keys. |
| charts/gitea/templates/gitea/sshService.yaml | Switches to the SSH Service name helper and reorders metadata keys. |
| charts/gitea/templates/gitea/ingress.yaml | Updates ingress backend service name to use the helper. |
| charts/gitea/templates/gitea/route.yaml | Updates OpenShift Route backend service name to use the helper. |
| charts/gitea/templates/gitea/_httpRoutes.tpl | Adds helpers for HTTPRoute enablement/labels/annotations. |
| charts/gitea/templates/gitea/httpRoute.yaml | Adds HTTPRoute template for Gateway API exposure. |
| charts/gitea/templates/gitea/_tcpRoutes.tpl | Adds helpers for TCPRoute enablement/labels/annotations. |
| charts/gitea/templates/gitea/tcpRoute.yaml | Adds TCPRoute template for (typically) SSH exposure. |
| charts/gitea/templates/gitea/_backendTLSPolicies.tpl | Adds helpers for BackendTLSPolicy enablement/labels/annotations. |
| charts/gitea/templates/gitea/backendTLSPolicy.yaml | Adds BackendTLSPolicy template for encrypted backend validation. |
| charts/gitea/templates/gitea/_clientSettingsPolicies.tpl | Adds helpers for NGINX ClientSettingsPolicy enablement/labels/annotations. |
| charts/gitea/templates/gitea/clientSettingsPolicy.yaml | Adds ClientSettingsPolicy template to raise request body limits (NGINX Gateway Fabric). |
| charts/gitea/docs/gateway-api.md | Adds a detailed Gateway API usage guide and topology notes. |
| charts/gitea/README.md | Updates docs navigation and adds a short Gateway API section + parameter table entries. |
| charts/gitea/.github/copilot-instructions.md | Adds chart-local contributor guidance for Copilot usage. |
Comment on lines
+1
to
+16
| {{- if eq (include "gitea.tcpRoute.enabled" .) "true" -}} | ||
| --- | ||
| apiVersion: gateway.networking.k8s.io/v1alpha2 | ||
| kind: TCPRoute | ||
| metadata: | ||
| {{- with (include "gitea.tcpRoute.annotations" .) }} | ||
| annotations: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| {{- with (include "gitea.tcpRoute.labels" .) }} | ||
| labels: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| name: {{ include "gitea.fullname" . }} | ||
| namespace: {{ .Values.namespace | default .Release.Namespace }} | ||
| spec: |
Comment on lines
+1
to
+19
| {{- if eq (include "gitea.backendTLSPolicy.enabled" .) "true" -}} | ||
| {{- if not (keys .Values.gatewayAPI.core.backendTLSPolicy.validation) }} | ||
| {{- fail "gatewayAPI.core.backendTLSPolicy.validation is required" }} | ||
| {{- end }} | ||
| --- | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: BackendTLSPolicy | ||
| metadata: | ||
| {{- with (include "gitea.backendTLSPolicy.annotations" .) }} | ||
| annotations: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| {{- with (include "gitea.backendTLSPolicy.labels" .) }} | ||
| labels: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| name: {{ include "gitea.fullname" . }} | ||
| namespace: {{ .Values.namespace | default .Release.Namespace }} | ||
| spec: |
Comment on lines
+1
to
+19
| {{- if eq (include "gitea.clientSettingsPolicies.enabled" .) "true" -}} | ||
| {{- if not (keys .Values.gatewayAPI.nginx.clientSettingsPolicies.body) }} | ||
| {{- fail "gatewayAPI.nginx.clientSettingsPolicies.body is required" }} | ||
| {{- end }} | ||
| --- | ||
| apiVersion: gateway.nginx.org/v1alpha1 | ||
| kind: ClientSettingsPolicy | ||
| metadata: | ||
| {{- with (include "gitea.clientSettingsPolicies.annotations" .) }} | ||
| annotations: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| {{- with (include "gitea.clientSettingsPolicies.labels" .) }} | ||
| labels: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| name: {{ include "gitea.fullname" . }} | ||
| namespace: {{ .Values.namespace | default .Release.Namespace }} | ||
| spec: |
|
|
||
| #### Gateway API | ||
|
|
||
| The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`). |
Comment on lines
+1
to
+16
| {{- if eq (include "gitea.httpRoute.enabled" .) "true" -}} | ||
| --- | ||
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| {{- with (include "gitea.httpRoute.annotations" .) }} | ||
| annotations: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| {{- with (include "gitea.httpRoute.labels" .) }} | ||
| labels: | ||
| {{- . | nindent 4 }} | ||
| {{- end }} | ||
| name: {{ include "gitea.fullname" . }} | ||
| namespace: {{ .Values.namespace | default .Release.Namespace }} | ||
| spec: |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated no new comments.
Suppressed comments (1)
charts/gitea/README.md:318
- README claims the chart can render an optional
Gateway, butdocs/gateway-api.mdexplicitly states the chart does not render aGatewayresource. This is contradictory and may mislead users configuring Gateway API exposure.
The chart can also expose Gitea through Gateway API resources (`HTTPRoute`, `TCPRoute`, `BackendTLSPolicy`, and optionally `Gateway`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency gitea to version 12.7.0.