chore(chart-deps): update tekton-pipelines to version 1.14.0 - #3512
Draft
svcAPLBot wants to merge 2 commits into
Draft
chore(chart-deps): update tekton-pipelines to version 1.14.0#3512svcAPLBot wants to merge 2 commits into
svcAPLBot wants to merge 2 commits into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the vendored Tekton Pipelines Helm chart content in APL Core to align with Tekton Pipelines v1.14.0, including images, labels, and CRDs used by the platform’s Tekton installation.
Changes:
- Bump Tekton Pipelines chart/dependency/app metadata from 1.12.0 → 1.14.0.
- Update controller/webhook/resolvers/events controller image references and the various
pipeline.tekton.dev/release/versionlabels to v1.14.0. - Refresh Tekton CRDs and values (including new
imagePullSecretsoptions and theenable-termination-message-compressionfeature flag).
Reviewed changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| charts/tekton-pipelines/values.yaml | Bumps component images to v1.14.0, adds imagePullSecrets knobs, and updates feature flag docs/options. |
| charts/tekton-pipelines/templates/webhook.pipeline.tekton.dev-mutwebhookcfg.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/webhook-certs-secret.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/validation.webhook.pipeline.tekton.dev-valwebhookcfg.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-webhook-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-webhook-horizontalpodautoscaler.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml | Updates version/release labels to v1.14.0 and adds webhook imagePullSecrets wiring. |
| charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml | Updates version/release labels to v1.14.0 and adds resolvers imagePullSecrets wiring. |
| charts/tekton-pipelines/templates/tekton-pipelines-controller-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml | Updates version/release labels to v1.14.0 and adds controller imagePullSecrets wiring. |
| charts/tekton-pipelines/templates/tekton-events-controller-svc.yaml | Updates version/release labels to v1.14.0. |
| charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml | Updates version/release labels to v1.14.0 and adds events controller imagePullSecrets wiring. |
| charts/tekton-pipelines/templates/pipelines-info-cm.yaml | Updates reported Tekton version to v1.14.0. |
| charts/tekton-pipelines/templates/config.webhook.pipeline.tekton.dev-valwebhookcfg.yaml | Updates Tekton release label to v1.14.0. |
| charts/tekton-pipelines/templates/config-tracing-cm.yaml | Adds a note about trace contents/security implications. |
| charts/tekton-pipelines/crds/verificationpolicies.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0. |
| charts/tekton-pipelines/crds/tasks.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0 and refreshes schema content. |
| charts/tekton-pipelines/crds/taskruns.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0 and refreshes schema content. |
| charts/tekton-pipelines/crds/stepactions.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0. |
| charts/tekton-pipelines/crds/pipelines.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0 and refreshes schema docs/content. |
| charts/tekton-pipelines/crds/pipelineruns.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0 and refreshes schema content. |
| charts/tekton-pipelines/crds/customruns.tekton.dev-crd.yaml | Updates CRD labels to v1.14.0. |
| charts/tekton-pipelines/Chart.yaml | Bumps chart version and appVersion to 1.14.0. |
| charts/dependencies.yaml | Bumps tekton-pipeline dependency version to 1.14.0. |
| apps.yaml | Updates Tekton appVersion metadata to 1.14.0. |
Comment on lines
+15
to
+17
| # NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun | ||
| # names and namespaces) as span attributes. Treat the trace backend as a trusted observability | ||
| # system. See docs/developers/tracing.md for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 26 out of 26 changed files in this pull request and generated no new comments.
Suppressed comments (5)
charts/tekton-pipelines/templates/config-tracing-cm.yaml:17
- This note references
docs/developers/tracing.md, but that file doesn’t exist in the repo. Update the reference so the comment doesn’t point to a dead path.
# NOTE: Exported traces may include Kubernetes resource identifiers (e.g. TaskRun/PipelineRun
# names and namespaces) as span attributes. Treat the trace backend as a trusted observability
# system. See docs/developers/tracing.md for details.
charts/tekton-pipelines/templates/tekton-pipelines-webhook-deploy.yaml:133
imagePullSecrets:is rendered unconditionally, but thewithblock won’t run for the default empty list ([]), producingimagePullSecrets: nullin the Pod spec. Kubernetes expects an array here; this can make the rendered manifest invalid. Render the entireimagePullSecretsfield only when non-empty.
imagePullSecrets:
{{- with .Values.webhook.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-controller-deploy.yaml:148
imagePullSecrets:is emitted even when.Values.controller.imagePullSecretsis the default empty list, resulting inimagePullSecrets: nullin the rendered Pod spec. This should be omitted unless there are secrets configured.
imagePullSecrets:
{{- with .Values.controller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-pipelines-remote-resolvers-deploy.yaml:114
- This renders
imagePullSecrets:even when.Values.remoteresolver.imagePullSecretsis an empty list, leavingimagePullSecrets: nullin the manifest. Wrap the field itself in the conditional so the key is omitted when not needed.
imagePullSecrets:
{{- with .Values.remoteresolver.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
charts/tekton-pipelines/templates/tekton-events-controller-deploy.yaml:107
imagePullSecrets:is currently output even when.Values.eventscontroller.imagePullSecretsis empty, which renders asnull. Kubernetes expects an array, so the key should be omitted unless secrets are provided.
imagePullSecrets:
{{- with .Values.eventscontroller.imagePullSecrets }}
{{- toYaml . | nindent 6 }}
{{- end }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency tekton-pipeline to version 1.14.0.