feat: deactivate git-server where not needed

[merll]

📌 Summary

This PR sets a default value for apps.git-server.enabled in the bootstrap process, depending whether the internal Git server is needed (either URL unset, or explicitly set to the internal Git URL) or an external Git source is used. Explicit input values remain unchanged.

A one-off migration is added for existing clusters which are running on an external Git server, but still have the platform built-in Git server enabled. It deactivates the app.

When migrating an internal to an external Git source, git-server is switched off by a values change in the API. This is provided by the following feature branch: linode/apl-api#1098

🔍 Reviewer Notes

🧹 Checklist

• Code is readable, maintainable, and robust.
• Unit tests added/updated

[Copilot]

Copilot review overview

🟡 Changes recommended

The bootstrap change breaks existing test expectations, and the new migration behavior lacks coverage.

Review effort: Balanced
Findings: 2

Open (2)

• Update bootstrap tests for Git server enablement behavior · New
• Add migration tests for Git server URL handling · New

What changed in this PR

Centralizes Git repository source detection and disables the built-in Git server when external Git is configured.

Changes:

• Adds derived Git source classification for templates.
• Defaults Git server off and adds bootstrap/migration handling.
• Advances the values specification to version 75.

Template comparison could not run because the required tsx dependency was unavailable.

File	Description
values/​team-ns/​team-ns.gotmpl	Uses derived Git source classification.
values/​argocd/​argocd-raw.gotmpl	Selects Argo CD credentials by Git source.
values-changes.yaml	Registers migration version 75.
tests/​fixtures/​env/​settings/​versions.yaml	Updates fixture specification version.
src/​cmd/​migrate.ts	Disables Git server for external repositories.
src/​cmd/​bootstrap.ts	Enables Git server for internal bootstrap configurations.
helmfile.d/​snippets/​derived.gotmpl	Derives Git source and effective enablement.
helmfile.d/​snippets/​defaults.yaml	Defaults Git server to disabled.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[svcAPLBot]

Comparison of Helm chart templating output:

# New file added: apl-network-policies/templates/networkpolicies/git-server.yaml
# Old file deleted: git-server-git-server
# Old file deleted: git-server-git-server-artifacts
# otomi-api/templates/configmap.yaml

@@ data.VERSIONS @@
! ± value change in multiline text (one insert, one deletion)
  {
    "api": "main",
    "aplCharts": "main",
    "console": "main",
    "consoleLogin": "main",
    "core": "main",
-   "specVersion": 74,
+   "specVersion": 75,
    "tasks": "main",
    "tools": "main",
    "tty": "1.2.8"
  }

# otomi-api/templates/deployment.yaml

# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml

# values-repo.yaml

@@ versions.specVersion @@
! ± value change
- 74
+ 75

[Copilot]

Copilot review overview

🟡 Changes recommended

Bootstrap persists a sticky enablement override, and the migration’s internal/external behavior lacks tests.

Review effort: Balanced
Findings: 1 · 2

Open (3)

• Avoid persisting derived Git server enablement · New
• Add migration tests for Git server URL handling
• Update bootstrap tests for Git server enablement behavior

[Copilot]

Copilot review overview

🟡 Changes recommended

Bootstrap persistence and migration behavior can respectively prevent later deactivation and overwrite explicit user enablement.

Review effort: Balanced
Findings: 2 · 2

Open (4)

• Migration overwrites explicit git-server opt-in for external repositories · New
• Avoid persisting derived Git server enablement
• Add migration tests for Git server URL handling
• Update bootstrap tests for Git server enablement behavior

[Copilot]

Copilot review overview

🟡 Changes recommended

Bootstrap can disable the internal Git service when partial external Git input falls back to internal configuration, and migration coverage is missing.

Review effort: Balanced
Findings: 1

Open (1)

• Base Git server disablement on the resolved Git configuration · New

Resolved since last review (4)

• Migration overwrites explicit git-server opt-in for external repositories
• Avoid persisting derived Git server enablement
• Add migration tests for Git server URL handling
• Update bootstrap tests for Git server enablement behavior

[CasLubbers]

git-server was not enabled when installing through BYO-Git