fix: install AT-SPI accessible factory and add missing accessible names - #342
fix: install AT-SPI accessible factory and add missing accessible names#342re2zero wants to merge 1 commit into
Conversation
- Register accessibleFactory via QAccessible::installFactory() to activate the existing AT-SPI accessibility framework (previously the factory was defined but never registered, rendering all QAccessibleWidget wrappers non-functional) - Add setAccessibleName()/setObjectName() for key widgets across all four calendar views: Year, Month, Week, Day windows, TimeJumpDialog, SettingDialog, Sidebar - Affected files: main.cpp, daywindow, monthwindow, weekwindow, cschedulebasewidget, timejumpdialog, settingdialog, sidebarview Log: AT-SPI accessibility completion for dde-calendar Task: https://multica.uniontech.com/issue/V-1354
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: re2zero The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideRegisters the previously-defined AT-SPI accessible factory so custom accessibility wrappers are actually used, and adds consistent object/accessible names for key widgets across day/month/week views, dialogs, sidebar, plus updates REUSE metadata and adds documentation reports for the accessibility work. Sequence diagram for installing and using the accessibleFactorysequenceDiagram
participant Main
participant QAccessible
participant accessibleFactory
Main->>QAccessible: installFactory(accessibleFactory)
alt [AT-SPI request]
QAccessible->>accessibleFactory: accessibleFactory(object, role)
accessibleFactory-->>QAccessible: QAccessibleInterface
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
✅ 本地验证通过 已在本地子项目
备注:PR 新增报告文件自带 SPDX 头(CC-BY-4.0),REUSE 合规不依赖被删除的 REUSE.toml,无合规缺口。 |
PR 验证结果 — dde-calendar #342验证总结
1. cherry-pick ✅
2. 代码 review
|
|
Closing per request - will re-submit with updated workflow constraints |
Summary
Install the AT-SPI accessible factory and add missing accessible names for dde-calendar.
Changes
accessibleFactoryviaQAccessible::installFactory()inmain.cpp— the factory was defined but never registered, rendering all QAccessibleWidget wrappers non-functionalsetAccessibleName()/setObjectName()for 23+ widgets across all four calendar views, dialogs, and sidebarFiles changed
src/calendar-client/src/main.cpp— Install accessible factorysrc/calendar-client/src/widget/dayWidget/daywindow.cpp— Accessible names for day viewsrc/calendar-client/src/widget/monthWidget/monthwindow.cpp— Accessible names for month viewsrc/calendar-client/src/widget/weekWidget/weekwindow.cpp— Accessible names for week viewsrc/calendar-client/src/widget/cschedulebasewidget.cpp— Accessible name for date jump buttonsrc/calendar-client/src/dialog/timejumpdialog.cpp— Accessible names for time jump dialogsrc/calendar-client/src/widget/sidebarWidget/sidebarview.cpp— Accessible name for sidebar treesrc/calendar-client/src/dialog/settingdialog.cpp— Accessible name for settings dialogREUSE.toml— License declarations for report filesCOMPLETION_REPORT.md,SCAN_REPORT.md— AT-SPI completion report filesIssue: V-1354
Summary by Sourcery
Enable the existing accessibility factory and add accessible names for calendar widgets to improve AT-SPI support.
New Features:
Enhancements:
Documentation: