Skip to content

fix: prevent crash when loadarchive #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-lvs merged 1 commit into from
Apr 14, 2026
Merged

fix: prevent crash when loadarchive #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/source/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2610,7 +2610,7 @@ bool MainWindow::handleArguments_Open(const QStringList &listParam)
if (UiTools::isWayland() && firstLoad) {
firstLoad = false;
auto path = listParam[0];
QTimer::singleShot(200, [this, &path]() {
QTimer::singleShot(200, [this, path]() {
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Use a QObject context or a safe pointer instead of capturing this in a delayed lambda to avoid potential use-after-free.

Because this runs 200 ms later without a QObject context, this may already be destroyed (e.g., if the window closes quickly), leading to a use-after-free in loadArchive(path). Please use the QTimer::singleShot overload that takes a QObject context, or capture a QPointer<MainWindow> and check it before calling loadArchive.

loadArchive(path);
});
} else {
Expand Down
Loading