Skip to content

chore:: Update CLA check workflow to inherit secrets #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-lvs merged 1 commit into from
Apr 16, 2026
Merged

chore:: Update CLA check workflow to inherit secrets #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/call-clacheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ concurrency:
jobs:
clacheck:
uses: linuxdeepin/.github/.github/workflows/cla-check.yml@master
secrets:
APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
secrets: inherit
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 issue (security): Using secrets: inherit may overexpose secrets compared to the previous least-privilege setup.

The previous version exposed only APP_PRIVATE_KEY, while secrets: inherit makes all repo/org secrets available to the called workflow. If that workflow only needs APP_PRIVATE_KEY, prefer an explicit mapping (updated to the new secrets syntax if required) to minimize exposure should the downstream workflow change or be compromised.

Loading