Skip to content

fix: Prevent overwriting error states on successful exit codes in Cli… #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Apr 28, 2026
+6 −2
Merged

fix: Prevent overwriting error states on successful exit codes in Cli… #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions 3rdparty/interface/archiveinterface/cliinterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,10 @@ void CliInterface::processFinished(int exitCode, QProcess::ExitStatus exitStatus
m_isCorruptArchive = false;
}

if (exitCode == 0) { // job正常结束
// If we already detected an error from stdout parsing, do not overwrite it
// just because the cli tool exits with code 0 (e.g. unrar may return 0 even
// when some entries fail to extract, such as long file name cases).
if (exitCode == 0 && m_finishType != PFT_Error && m_finishType != PFT_Cancel) {
m_finishType = PFT_Nomral;
}

Expand All @@ -1403,7 +1406,8 @@ void CliInterface::extractProcessFinished(int exitCode, QProcess::ExitStatus exi

deleteProcess();

if (0 == exitCode) { // job正常结束
// Keep stdout-detected errors (e.g. long name) even if exitCode is 0.
if (0 == exitCode && m_finishType != PFT_Error && m_finishType != PFT_Cancel) {
m_finishType = PFT_Nomral;
}

Expand Down
Loading