Skip to content

fix: Opening a file without permission results in a blank page #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzwind merged 2 commits into from
Apr 23, 2026
Merged

fix: Opening a file without permission results in a blank page #451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8439b7a
fix: Opening a file without permission results in a blank page
JWWTSL Apr 23, 2026
26ef899
Merge branch 'master' into master
lzwind Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/widgets/window.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,15 +675,22 @@ void Window::addTab(const QString &filepath, bool activeTab)
}
}

// check if have permission to read the file.
bool bIsReadable = fileInfo.isReadable();
qDebug() << "File readable:" << bIsReadable;

if (fileInfo.exists() && !bIsReadable) {
qWarning() << "No permission to read file:" << filepath;
DMessageManager::instance()->sendMessage(m_editorWidget->currentWidget(), QIcon(":/images/warning.svg")
, QString(tr("You do not have permission to open %1")).arg(filepath));
return;
// Verify the file is actually readable by attempting to open it.
// This is more reliable than QFileInfo::isReadable(), which can be incorrect
// in some edge cases (e.g. setuid processes, certain filesystems).
if (fileInfo.exists()) {
QFile testFile(filepath);
if (testFile.open(QIODevice::ReadOnly)) {
testFile.close();
} else if (testFile.error() == QFileDevice::PermissionsError) {
qWarning() << "No permission to read file:" << filepath << "error:" << testFile.errorString();
Comment thread
sourcery-ai[bot] marked this conversation as resolved.
QWidget *const msgParent = m_editorWidget->currentWidget() ? m_editorWidget->currentWidget() : this;
DMessageManager::instance()->sendMessage(msgParent, QIcon(":/images/warning.svg"),
QString(tr("You do not have permission to open %1")).arg(filepath));
return;
} else {
qWarning() << "Failed to open file:" << filepath << "error:" << testFile.errorString();
}
}

if (StartManager::instance()->checkPath(filepath)) {
Expand Down
Loading