refactor(excel): remove unused biffh header file#55
Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/20260424from Apr 28, 2026
Merged
refactor(excel): remove unused biffh header file#55deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/20260424from
deepin-bot[bot] merged 1 commit intolinuxdeepin:develop/20260424from
Conversation
Remove the biffh.hpp header file which is no longer used in the Excel parsing module. This file contained BIFF record definitions and was likely part of an older implementation approach. Log: refactor(excel): remove unused biffh header file Task: https://pms.uniontech.com/task-view-388905.html
deepin pr auto review |
|
Note
详情{
"3rdparty/libs/fileext/excel/xlsxio/xlsxio_read.c": [
{
"line": " if (XML_Char_icmp(reltype, X(\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/worksheet\")) == 0) {",
"line_number": 845,
"rule": "S35",
"reason": "Url link | 591ded0820"
},
{
"line": " } else if (XML_Char_icmp(reltype, X(\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/sharedStrings\")) == 0) {",
"line_number": 853,
"rule": "S35",
"reason": "Url link | b67c93b15a"
},
{
"line": " } else if (XML_Char_icmp(reltype, X(\"http://schemas.openxmlformats.org/officeDocument/2006/relationships/styles\")) == 0) {",
"line_number": 858,
"rule": "S35",
"reason": "Url link | 7b6758f750"
}
]
} |
max-lvs
approved these changes
Apr 28, 2026
Johnson-zs
approved these changes
Apr 28, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs, max-lvs, pppanghu77 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/forcemerge |
Contributor
|
This pr force merged! (status: unstable) |
5bc3e67
into
linuxdeepin:develop/20260424
18 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the biffh.hpp header file which is no longer used in the Excel parsing module. This file contained BIFF record definitions and was likely part of an older implementation approach. Log: refactor(excel): remove unused biffh header file Task: https://pms.uniontech.com/task-view-388905.html