Skip to content

fix(slider): increase focus border paddings for Slider visibility #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhduiy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(slider): increase focus border paddings for Slider visibility #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions qt6/src/qml/FlowStyle.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -958,6 +958,8 @@ QtObject {
property int height: 60
property int highlightMargin: -4

property int focusBorderPaddings: 5

property QtObject handle: QtObject {
property int width: 20
property int height: 24
Expand Down
3 changes: 2 additions & 1 deletion qt6/src/qml/FocusBoxBorder.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,12 @@ Item {
property color color: palette.highlight
property real borderWidth: DS.Style.control.focusBorderWidth
property real radius: DS.Style.control.radius
property real focusBorderPaddings: DS.Style.control.focusBorderPaddings

@18202781743 18202781743 Sep 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个变量名称改一下吧，控件已经是FocusBox的，不需要加这种前缀，


Rectangle {
id: _border

readonly property real paddings: borderWidth + DS.Style.control.focusBorderPaddings
readonly property real paddings: borderWidth + control.focusBorderPaddings

anchors {
fill: parent
Expand Down
4 changes: 3 additions & 1 deletion qt6/src/qml/Slider.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ T.Slider {
Loader {
anchors.fill: parent
active: control.visualFocus
sourceComponent: FocusBoxBorder {}
sourceComponent: FocusBoxBorder {
focusBorderPaddings: DS.Style.slider.focusBorderPaddings
}
}
}

Expand Down
Loading