Repository navigation
Release 6.7.51 - #723
Release 6.7.51#723
Conversation
|
Hi @deepin-bot[bot]. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis release PR updates version and distribution packaging metadata from 6.7.50 to 6.7.51 and documents two previously implemented changes: Mongolian translation support for dtkdeclarative.ts and corrected popup sizing before mapping. The functional implementation for those changes is not included in the provided diff, so reviewers should verify it in the referenced commits or the comparison range. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="CHANGELOG.md" line_range="16" />
<code_context>
+
+### Fixed
+
+- Size popup before it is mapped
+
## [6.7.50] - 2026-09-22
</code_context>
<issue_to_address>
**Qt 5 popup sizing remains broken**
When a consumer uses the default DTK 5 build and opens the combo box before its list has been laid out, the Qt 5 `ComboBox` still derives popup height from `ArrowListView`'s `ListView.contentHeight`; before the list is laid out, that value is not yet measured, so the popup maps at the wrong height.
Apply equivalent pre-map popup sizing to the Qt 5 ComboBox and ArrowListView path.
</issue_to_address>|
|
||
| ### Fixed | ||
|
|
||
| - Size popup before it is mapped |
There was a problem hiding this comment.
🟠 High · Qt 5 popup sizing remains broken
When a consumer uses the default DTK 5 build and opens the combo box before its list has been laid out, the Qt 5 ComboBox still derives popup height from ArrowListView's ListView.contentHeight; before the list is laid out, that value is not yet measured, so the popup maps at the wrong height.
Apply equivalent pre-map popup sizing to the Qt 5 ComboBox and ArrowListView path.
Prompt for AI agents
In `CHANGELOG.md` at line 16:
**Qt 5 popup sizing remains broken**
When a consumer uses the default DTK 5 build and opens the combo box before its list has been laid out, the Qt 5 `ComboBox` still derives popup height from `ArrowListView`'s `ListView.contentHeight`; before the list is laid out, that value is not yet measured, so the popup maps at the wrong height.
Apply equivalent pre-map popup sizing to the Qt 5 ComboBox and ArrowListView path.
18202781743
left a comment
18202781743
left a comment
There was a problem hiding this comment.
Release version and generated changelog metadata look correct.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, deepin-bot[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot TAG: 6.7.51 |
|
TAG Bot ✅ Tag created successfully 📋 Tag Details
|
Changelog
All notable changes to this project will be documented in this file.
The format is based on Keep a Changelog,
and this project adheres to Semantic Versioning.
6.7.51 - 2026-10-15
Changed
Fixed
This PR is triggered by @18202781743
Summary by Sourcery
Release version 6.7.51 with Mongolian localization and corrected popup sizing.
Bug Fixes:
Enhancements:
Build:
Documentation: