Skip to content

fix(ArrowListView): keep arrows always visible and grey by scroll position #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
18202781743 merged 1 commit into from
Oct 20, 2026
+10 −10
Merged

fix(ArrowListView): keep arrows always visible and grey by scroll position #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions qt6/src/qml/ArrowListView.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,23 @@ FocusScope {
return 0
const item = itemsView.itemAtIndex(0)
const measured = itemsView.contentHeight > 0 && item ? (item.height || item.implicitHeight) : 0
const arrowStrips = itemsView.count > maxVisibleItems
? 2 * (DS.Style.arrowListView.stepButtonIconSize.height + contentLayout.spacing) : 0
return Math.min(itemsView.count, maxVisibleItems) * (measured > 0 ? measured : itemHeight) + arrowStrips
const arrowStrips = 2 * (DS.Style.arrowListView.stepButtonSize.height + contentLayout.spacing)
return Math.min(itemsView.count, maxVisibleItems) * (measured > 0 ? measured : itemHeight) + arrowStrips + contentLayout.anchors.topMargin
}

implicitWidth: Math.max(DS.Style.arrowListView.width, contentLayout.implicitWidth)
implicitHeight: contentLayout.implicitHeight
implicitHeight: contentLayout.implicitHeight + contentLayout.anchors.topMargin

ColumnLayout {
id: contentLayout
anchors.fill: parent
anchors.topMargin: 6
spacing: 6
P.ArrowListViewButton {
visible: itemsView.interactive
Layout.alignment: Qt.AlignHCenter
Layout.fillWidth: true
Layout.preferredHeight: DS.Style.arrowListView.stepButtonIconSize.height
Layout.preferredHeight: DS.Style.arrowListView.stepButtonSize.height
Layout.minimumHeight: DS.Style.arrowListView.stepButtonSize.height
view: itemsView
stepSize: control.itemHeight
direction: P.ArrowListViewButton.UpButton
Expand Down Expand Up @@ -90,10 +91,10 @@ FocusScope {
}

P.ArrowListViewButton {
visible: itemsView.interactive
Comment thread
zqq-dora marked this conversation as resolved.
Layout.alignment: Qt.AlignHCenter
Layout.fillWidth: true
Layout.preferredHeight: DS.Style.arrowListView.stepButtonIconSize.height
Layout.preferredHeight: DS.Style.arrowListView.stepButtonSize.height
Layout.minimumHeight: DS.Style.arrowListView.stepButtonSize.height
view: itemsView
stepSize: control.itemHeight
direction: P.ArrowListViewButton.DownButton
Expand Down
3 changes: 1 addition & 2 deletions qt6/src/qml/private/ArrowListViewButton.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2022 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2022 - 2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: LGPL-3.0-or-later

Expand All @@ -15,7 +15,6 @@ Loader {
required property Item view
property int direction
property int stepSize: DS.Style.arrowListView.itemHeight
active: view.interactive
Comment thread
zqq-dora marked this conversation as resolved.

sourceComponent: ActionButton {
palette.windowText: undefined
Expand Down
Loading