Skip to content

ci: only run build workflows on pull_request - #417

Closed
deepin-wm wants to merge 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/developer/7872e6aa2850
Closed

deepin-wm wants to merge 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/developer/7872e6aa2850

Conversation

@deepin-wm

@deepin-wm deepin-wm commented Oct 8, 2026 •

Copy link
Copy Markdown

背景

构建类 GitHub Actions 工作流原本在 push 和 pull_request 两个事件下都会运行,主干每次推送都会触发一轮完整构建。按需求,构建类 workflow 只需在 pull_request 下运行,push 触发移除。

改动内容

删除以下构建类 workflow 的 push 触发,仅保留 pull_request:

  • .github/workflows/dtkgui-archlinux-build.yml
  • .github/workflows/dtkgui-deepin-build.yml

on: 块只删不加,未新增或改写任何其它触发键。

为什么这么改

构建 workflow 里没有依赖 push 事件的分支逻辑,移除触发不会让任何步骤失效;这些 workflow 也只通过 actions/upload-artifact@v4 上传产物,不做 release/部署/推包,因此对对外产物无影响。

刻意未改动的部分

call-build-distribution.yml 保留 push:它复用的 linuxdeepin/.github 通用流程按事件分流,github.event_name == 'push' 时才导入 GPG 私钥、上传软件包到 distribution 源,属于发版/推包链路而非 PR 校验型构建,删除 push 会掐断发行路径。call-deploy-dev-doc.yml(push 部署开发文档)同理不属构建类。

关联

Summary by Sourcery

Restrict dtkgui build workflow execution to pull requests to avoid redundant builds on direct pushes.

Enhancements:

  • Run Arch Linux and Deepin build workflows only for pull requests by removing their push triggers.

CI:

  • Limit the dtkgui Arch Linux and Deepin GitHub Actions build workflows to pull_request events while leaving release and deployment workflows unchanged.

Remove the push trigger from build workflows, keeping pull_request only.

移除构建类 workflow 的 push 触发,仅保留 pull_request 触发。

Log: 构建类 workflow 仅保留 pull_request 触发
Influence: 主干分支不再触发构建校验,PR 的构建校验行为保持不变。
Multica Issue: WM-565
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sourcery-ai

sourcery-ai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR prevents redundant branch-push builds for the Arch Linux and Deepin validation workflows while preserving pull request checks; release and deployment workflows remain unaffected.

File-Level Changes

Change Details Files
Restrict the Arch Linux and Deepin build workflows to pull request events by removing their push triggers.
  • Delete the push entries from each workflow’s on: configuration.
  • Preserve the existing pull_request triggers and all build jobs unchanged.
.github/workflows/dtkgui-archlinux-build.yml
.github/workflows/dtkgui-deepin-build.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-wm, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs
zccrs marked this pull request as ready for review October 10, 2026 02:36
@zccrs

zccrs commented Oct 10, 2026

Copy link
Copy Markdown
Member

只是想修改treeland, 这是一个意外的提交

@zccrs zccrs closed this Oct 10, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants