refactor: convert shared form helpers and components to TypeScript (CM-1579)

[gaspergrom]

Summary

Converts the shared form helpers and components (element-change, form-change, form-errors, form-item, inline-select-input, array-input) to TypeScript. The type-check baseline drops from 538 to 536.

• The six files leave .eslint/legacy-files.json.

JIRA: https://linuxfoundation.atlassian.net/browse/CM-1579

[cursor]

PR Summary

Low Risk
Type-only and Vue API modernization on shared form UI; behavior should match aside from minor defaults (e.g. empty options array).

Overview
Migrates six shared form pieces—array-input, form-errors, form-item, inline-select-input, element-change, and form-change—to TypeScript with <script setup lang="ts">, defineOptions, and typed props, emits, and slots (including Vuelidate ErrorObject on error UI).

form-change moves from .js to .ts with explicit return types; inline-select-input gains an InlineSelectOption interface and defaults options to an empty array instead of {}. Legacy ESLint exemptions for these paths are removed, and the typecheck baseline drops from 538 to 534 errors.

^{Reviewed by Cursor Bugbot for commit 436e735. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Copilot]

🟡 Changes recommended

CI reports 534 type errors, so the baseline of 536 would permit two regressions.

1 open finding

• Typecheck baseline is two errors too high · New

What changed in this PR

Converts shared Vue form utilities and components to TypeScript while removing their ESLint legacy exemptions.

Changes:

• Adds typed props, emits, slots, and Vuelidate errors.
• Converts form-change.js to TypeScript.
• Updates ESLint exemptions and the type-check baseline.

File	Description
frontend/​typecheck-baseline.json	Lowers the type-error baseline.
frontend/​.eslint/​legacy-files.json	Removes converted components from legacy exemptions.
frontend/​src/​shared/​form/​array-input.vue	Adds TypeScript component definitions.
frontend/​src/​shared/​form/​element-change.ts	Types the element change detector.
frontend/​src/​shared/​form/​form-change.js	Removes the JavaScript implementation.
frontend/​src/​shared/​form/​form-change.ts	Adds the typed replacement implementation.
frontend/​src/​shared/​form/​form-errors.vue	Types validation errors and messages.
frontend/​src/​shared/​form/​form-item.vue	Types props, slots, and validation handling.
frontend/​src/​shared/​form/​inline-select-input.vue	Types options, props, and emitted events.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The TypeScript migration preserves existing behavior and the previously reported baseline mismatch is resolved.

0 open findings

1 resolved since last review

• Typecheck baseline is two errors too high

🧠 Review effort: Balanced

[themarolt]

lgtm