Skip to content

feat: show octolens mention platforms in cdp and fix the activity type filter - #4998

Merged
themarolt merged 10 commits into
mainfrom
feat/issue-748-octolens-platform-configs
Oct 16, 2026
Merged

themarolt merged 10 commits into
mainfrom
feat/issue-748-octolens-platform-configs

Conversation

@themarolt

Copy link
Copy Markdown
Contributor

Summary

Frontend support for the platforms the Octolens connector now emits mentions from (#4993). Bluesky, TikTok, Instagram and YouTube identities get a name, icon and profile link, and the activity-type filter works again: it has shown only custom activity types since January 2025, because its active-integrations helper always returned an empty list.

Changes

  • Identity configs and icons for bluesky, tiktok, instagram and youtube. Profile links are built from the identity value the connector stores: bsky.app/profile/<handle> (handles and did: identifiers), tiktok.com/@<handle>, instagram.com/<name>, youtube.com/channel/<id>. GitHub, X/Twitter, LinkedIn, Reddit, dev.to and Hacker News already had configs that match.
  • getActiveIntegrations read mapGetters('integrations'), but the store module is integration, so it always returned []. It now reads integration/array and returns every platform with an integration in the selected project group. Its only caller is the activity-type filter (activity list and member list).
  • Activity-type filter: each platform with an integration offers its full set of default types again, and while Octolens is active the ten platforms it emits from also offer Mention. The filter tolerates activity types that haven't loaded yet and builds its options immediately. octolensMentionPlatforms has to match ENABLED_PLATFORMS in the connector's mapper.
  • facebook/config.ts shows a formatting-only reflow applied by the repo's lint-staged hook.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

Related issue

Refs linuxfoundation/lfx-cdp-insights-ops#748

The Octolens connector emits mentions from GitHub, X/Twitter, LinkedIn,
Reddit, dev.to, Hacker News, Bluesky, TikTok, Instagram and YouTube. The
mention filter now lists exactly those, and the unused Medium and Product
Hunt configs and the Facebook change are dropped.

Refs linuxfoundation/lfx-cdp-insights-ops#748

Signed-off-by: Uroš Marolt <uros@marolt.me>
…s configs

Reading active integrations made the filter's watch fire before activity
types loaded, so it now tolerates missing types and runs immediately. The
integration helper reuses the Integration type, the Octolens platform list
is read-only and tied to the connector's allow-list, and the YouTube link
no longer falls back to an attribute Octolens never needs.

Refs linuxfoundation/lfx-cdp-insights-ops#748

Signed-off-by: Uroš Marolt <uros@marolt.me>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 11:44
@cursor

cursor Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches shared filter and integration helper logic used on activity and member lists; behavior change is intentional but could affect which activity-type options users see per project group.

Overview
Adds Bluesky, Instagram, TikTok, and YouTube to the CDP identity registry with icons and member profile URL builders, so Octolens mention data can display with the right branding and links in member/activity views.

Fixes the activity type filter, which had been limited to custom types because getActiveIntegrations read the wrong Vuex getter (integrations instead of integration/array). It now returns platforms with an active integration for the selected project group. When Octolens is active, the ten connector mention platforms (via octolensMentionPlatforms, aligned with the backend mapper) also get a Mention option even without a direct platform integration. Filter options build immediately with safe defaults, integration fetch runs on project-group change, and multiselect tag options refresh when parent options update.

Reviewed by Cursor Bugbot for commit 1af5a63. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Stale filter options, outdated project-group integrations, and missing profile links remain unresolved.

3 open findings
What changed in this PR

Adds frontend support for Octolens mention platforms and restores integration-based activity-type filtering.

Changes:

  • Registers four platform identities with icons and profile URL builders.
  • Fixes integration lookup and adds Octolens mention filter options.
  • Handles unloaded activity types and initializes options immediately.
File Description
frontend/​src/​shared/​modules/​filters/​components/​filterTypes/​ActivityTypeFilter.vue Adds mention options and immediate initialization.
frontend/​src/​config/​integrations/​octolens/​config.ts Declares supported mention platforms.
frontend/​src/​config/​integrations/​integrations.helpers.ts Corrects integration store lookup.
frontend/​src/​config/​identities/​youtube/​config.ts Adds YouTube identity configuration.
frontend/​src/​config/​identities/​tiktok/​config.ts Adds TikTok identity configuration.
frontend/​src/​config/​identities/​instagram/​config.ts Adds Instagram identity configuration.
frontend/​src/​config/​identities/​index.ts Registers the four identities.
frontend/​src/​config/​identities/​facebook/​config.ts Formatting-only reflow.
frontend/​src/​config/​identities/​bluesky/​config.ts Adds Bluesky identity configuration.
frontend/​src/​assets/​images/​identities/​youtube.svg Adds YouTube icon.
frontend/​src/​assets/​images/​identities/​tiktok.svg Adds TikTok icon.
frontend/​src/​assets/​images/​identities/​instagram.svg Adds Instagram icon.
frontend/​src/​assets/​images/​identities/​bluesky.svg Adds Bluesky icon.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread frontend/src/config/identities/index.ts
Comment thread frontend/src/config/integrations/integrations.helpers.ts
…r in sync

Identities grouped as custom (such as Bluesky, TikTok, Instagram and YouTube)
now resolve their profile link with their own platform's config instead of
'custom'. The activity type filter re-fetches integrations when the project
group changes, and the multi-select keeps its options in sync when they are
replaced, preserving the current search.

Refs linuxfoundation/lfx-cdp-insights-ops#748

Signed-off-by: Uroš Marolt <uros@marolt.me>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes address prior feedback, and no unresolved blocking issues remain.

0 open findings

3 resolved since last review

🧠 Review effort: Balanced

@themarolt
themarolt merged commit 72d2729 into main Oct 16, 2026
14 checks passed
@themarolt
themarolt deleted the feat/issue-748-octolens-platform-configs branch October 16, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants