Repository navigation
feat: show octolens mention platforms in cdp and fix the activity type filter - #4998
Conversation
Refs linuxfoundation/lfx-cdp-insights-ops#748 Signed-off-by: Uroš Marolt <uros@marolt.me>
… mention types Refs linuxfoundation/lfx-cdp-insights-ops#748 Signed-off-by: Uroš Marolt <uros@marolt.me>
Refs linuxfoundation/lfx-cdp-insights-ops#748 Signed-off-by: Uroš Marolt <uros@marolt.me>
Refs linuxfoundation/lfx-cdp-insights-ops#748 Signed-off-by: Uroš Marolt <uros@marolt.me>
…ns-platform-configs
The Octolens connector emits mentions from GitHub, X/Twitter, LinkedIn, Reddit, dev.to, Hacker News, Bluesky, TikTok, Instagram and YouTube. The mention filter now lists exactly those, and the unused Medium and Product Hunt configs and the Facebook change are dropped. Refs linuxfoundation/lfx-cdp-insights-ops#748 Signed-off-by: Uroš Marolt <uros@marolt.me>
…s configs Reading active integrations made the filter's watch fire before activity types loaded, so it now tolerates missing types and runs immediately. The integration helper reuses the Integration type, the Octolens platform list is read-only and tied to the connector's allow-list, and the YouTube link no longer falls back to an attribute Octolens never needs. Refs linuxfoundation/lfx-cdp-insights-ops#748 Signed-off-by: Uroš Marolt <uros@marolt.me>
…ns-platform-configs
PR SummaryMedium Risk Overview Fixes the activity type filter, which had been limited to custom types because Reviewed by Cursor Bugbot for commit 1af5a63. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
🟡 Changes recommended
Stale filter options, outdated project-group integrations, and missing profile links remain unresolved.
3 open findings
What changed in this PR
Adds frontend support for Octolens mention platforms and restores integration-based activity-type filtering.
Changes:
- Registers four platform identities with icons and profile URL builders.
- Fixes integration lookup and adds Octolens mention filter options.
- Handles unloaded activity types and initializes options immediately.
| File | Description |
|---|---|
| frontend/src/shared/modules/filters/components/filterTypes/ActivityTypeFilter.vue | Adds mention options and immediate initialization. |
| frontend/src/config/integrations/octolens/config.ts | Declares supported mention platforms. |
| frontend/src/config/integrations/integrations.helpers.ts | Corrects integration store lookup. |
| frontend/src/config/identities/youtube/config.ts | Adds YouTube identity configuration. |
| frontend/src/config/identities/tiktok/config.ts | Adds TikTok identity configuration. |
| frontend/src/config/identities/instagram/config.ts | Adds Instagram identity configuration. |
| frontend/src/config/identities/index.ts | Registers the four identities. |
| frontend/src/config/identities/facebook/config.ts | Formatting-only reflow. |
| frontend/src/config/identities/bluesky/config.ts | Adds Bluesky identity configuration. |
| frontend/src/assets/images/identities/youtube.svg | Adds YouTube icon. |
| frontend/src/assets/images/identities/tiktok.svg | Adds TikTok icon. |
| frontend/src/assets/images/identities/instagram.svg | Adds Instagram icon. |
| frontend/src/assets/images/identities/bluesky.svg | Adds Bluesky icon. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…r in sync Identities grouped as custom (such as Bluesky, TikTok, Instagram and YouTube) now resolve their profile link with their own platform's config instead of 'custom'. The activity type filter re-fetches integrations when the project group changes, and the multi-select keeps its options in sync when they are replaced, preserving the current search. Refs linuxfoundation/lfx-cdp-insights-ops#748 Signed-off-by: Uroš Marolt <uros@marolt.me>
…ns-platform-configs

Summary
Frontend support for the platforms the Octolens connector now emits mentions from (#4993). Bluesky, TikTok, Instagram and YouTube identities get a name, icon and profile link, and the activity-type filter works again: it has shown only custom activity types since January 2025, because its active-integrations helper always returned an empty list.
Changes
bluesky,tiktok,instagramandyoutube. Profile links are built from the identity value the connector stores:bsky.app/profile/<handle>(handles anddid:identifiers),tiktok.com/@<handle>,instagram.com/<name>,youtube.com/channel/<id>. GitHub, X/Twitter, LinkedIn, Reddit, dev.to and Hacker News already had configs that match.getActiveIntegrationsreadmapGetters('integrations'), but the store module isintegration, so it always returned[]. It now readsintegration/arrayand returns every platform with an integration in the selected project group. Its only caller is the activity-type filter (activity list and member list).Mention. The filter tolerates activity types that haven't loaded yet and builds its options immediately.octolensMentionPlatformshas to matchENABLED_PLATFORMSin the connector's mapper.facebook/config.tsshows a formatting-only reflow applied by the repo's lint-staged hook.Type of change
Related issue
Refs linuxfoundation/lfx-cdp-insights-ops#748