Skip to content

fix: describe mention activities as mentions of the project - #4999

Merged
themarolt merged 1 commit into
mainfrom
fix/issue-748-octolens-mention-wording
Oct 16, 2026
Merged

themarolt merged 1 commit into
mainfrom
fix/issue-748-octolens-mention-wording

Conversation

@themarolt

Copy link
Copy Markdown
Contributor

Summary

Mention activities were described as "mentioned you on Reddit", "mentioned you on GitHub" or "mentioned you in a tweet". In CDP these are mentions of an LF project, both the ones Octolens now ingests and the ones from a project's connected X/Twitter account, so the display text and the short label (used by the activity-type filter) now say "mentioned the project".

Changes

  • mention display text and short label for every platform that has one: GitHub, X/Twitter, LinkedIn, Reddit, DEV, Hacker News, Stack Overflow, Medium, Product Hunt, Facebook, YouTube, Bluesky, TikTok and Instagram.
  • The X/Twitter entry in prettyActivityTypes matches.
  • Display text only: activity types, scores and contribution flags are unchanged. The activityTypes table's existing (mention, twitter) label ("Mentioned a user") is left as is.

Type of change

  • Bug fix
  • New feature
  • Refactor / cleanup
  • Performance improvement
  • Chore / dependency update
  • Documentation

Related issue

Refs linuxfoundation/lfx-cdp-insights-ops#748

Mention activities read "mentioned you on Reddit" or "mentioned you in a
tweet", but in CDP they are mentions of an LF project, whether they come
from Octolens or from a project's connected X/Twitter account. The display
and short labels now say "mentioned the project".

Refs linuxfoundation/lfx-cdp-insights-ops#748

Signed-off-by: Uroš Marolt <uros@marolt.me>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 11:46
@cursor

cursor Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Copy-only changes to activity display strings with no logic, data, or API behavior changes.

Overview
Mention activity copy now describes project-level mentions instead of personal ones: default strings move from “mentioned you …” to “mentioned the project …”, and the shared short label becomes “mentioned the project” (including activity-type filters).

The shared mentionActivityType() helper in activityTypes.ts drives Reddit, DEV, Hacker News, Stack Overflow, Medium, Product Hunt, Facebook, YouTube, Bluesky, TikTok, and Instagram. GitHub, LinkedIn, and X/Twitter have explicit MENTION display entries updated in the same file (Twitter’s default also shifts to “on X/Twitter” instead of “in a tweet”). prettyActivityTypes.ts aligns the Twitter mention label with that wording.

Display text only—activity types, scoring, and contribution behavior are unchanged.

Reviewed by Cursor Bugbot for commit e29da56. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently update display strings without changing behavior, and no blocking issues were identified.

0 open findings

What changed in this PR

Updates CDP mention labels to describe mentions of the project rather than the user.

Changes:

  • Updates platform-specific and shared mention display text and filter labels.
  • Aligns the X/Twitter pretty label without changing activity identifiers, scores, or contribution flags.
File Description
services/​libs/​integrations/​src/​integrations/​prettyActivityTypes.ts Updates the X/Twitter mention label.
services/​libs/​integrations/​src/​integrations/​activityTypes.ts Updates shared and platform-specific mention labels.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@themarolt
themarolt merged commit 54b109e into main Oct 16, 2026
14 checks passed
@themarolt
themarolt deleted the fix/issue-748-octolens-mention-wording branch October 16, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants