[gaspergrom]

Summary

Deletes the unused settings Vuex store and its module registration. Nothing outside the store read it, and SettingsService is only used by it, so /settings and the API keys tab behave as before. settings-service.js stays for CM-1603.

• One stale settings-store to router line leaves cycles-allowlist.json.

Closes linuxfoundation/lfx-cdp-insights-ops#249

[cursor]

PR Summary

Low Risk
Deletes unused state management with no remaining references; settings routes and service stay in place.

Overview
Removes the settings Vuex module entirely: settings-store.js is deleted and settings-module.js no longer registers a store (routes-only module).

Also drops the corresponding settings-store → router path from cycles-allowlist.json. Settings UI and SettingsService are unchanged; this is dead-code cleanup with no new behavior.

^{Reviewed by Cursor Bugbot for commit 854014e. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Copilot]

🟢 Approval recommended

Reference tracing found no remaining store consumers, and the cleanup preserves routing and API-key functionality.

0 open findings

What changed in this PR

Removes the unused settings Vuex store while preserving settings routes and API-key behavior.

Changes:

• Deletes the store and its module registration.
• Removes the obsolete circular-dependency allowlist entry.
• Leaves settings-service.js for follow-up cleanup.

File	Description
frontend/​src/​modules/​settings/​settings-store.js	Deletes the unused Vuex store.
frontend/​src/​modules/​settings/​settings-module.js	Removes store registration; retains routes.
frontend/​cycles-allowlist.json	Removes the deleted store’s cycle entry.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

No remaining store consumers or unresolved issues were identified, and settings routing remains unchanged.

0 open findings

🧠 Review effort: Balanced