Pre-merge CI: Godot platform matrix

.github/sequence-lsan.supp

@@ -0,0 +1,7 @@
+# amy_reset_oscs() reinitializes the global bus filters without releasing the
+# previous filter arrays. This is present on the Shorepine-main baseline and is
+# outside the reusable-sequence ownership being validated here.
+leak:filters_init
+# Repeated amy_start()/amy_stop() in the baseline leaves replaced patch-slot
+# arrays allocated as well. Keep sequence allocations visible.
+leak:patches_init

.github/workflows/c-cpp.yml

@@ -111,7 +111,7 @@ jobs:
         python-version: '3.13'
 
     - name: Check generated C API bindings are in sync
-      run: make check-c-api
+      run: make check-c-api js-api-test
 
   godot-build:
     # Build the Godot GDExtension for Linux. amy_midi.c is excluded from the

.github/workflows/godot-addon.yml

@@ -4,6 +4,8 @@ on:
   push:
     tags:
       - '*'
+  pull_request:
+    branches: [ "main" ]
   workflow_dispatch:
 
 permissions:
@@ -15,14 +17,6 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - name: macOS
-            runner: macos-latest
-            platform: macos
-            arch: universal
-          - name: Linux
-            runner: ubuntu-22.04
-            platform: linux
-            arch: x86_64
           - name: Windows
             runner: windows-latest
             platform: windows
@@ -71,6 +65,7 @@ jobs:
 
   package:
     needs: build
+    if: github.event_name != 'pull_request'
     runs-on: ubuntu-latest
     name: Package Addon
 

.github/workflows/premerge-sequence-sanitizers.yml

@@ -0,0 +1,60 @@
+name: Pre-merge sequence sanitizers
+
+on:
+  pull_request:
+    branches: [ "main" ]
+
+jobs:
+  address-and-leak:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.13'
+      - name: Install header-generation dependency
+        run: pip install numpy
+      - name: Build sequence tests with AddressSanitizer
+        run: >-
+          make tests/test_sequencer_active tests/test_sequencer_bounds
+          tests/test_sequencer_sequences tests/test_sequencer_oom
+          tests/test_sequencer_concurrency
+          CFLAGS="-O1 -g -Wall -Wextra -Wno-unused-parameter
+          -Wno-strict-aliasing -Wno-float-conversion
+          -Wno-missing-declarations -Wpointer-arith -DAMY_WAVETABLE
+          -fsanitize=address -fno-omit-frame-pointer"
+      - name: Run legacy tests without process-exit leak checks
+        env:
+          ASAN_OPTIONS: detect_leaks=0:halt_on_error=1
+        run: |
+          tests/test_sequencer_active
+          tests/test_sequencer_bounds
+      - name: Run lifecycle tests with leak detection
+        env:
+          ASAN_OPTIONS: detect_leaks=1:halt_on_error=1
+          LSAN_OPTIONS: suppressions=.github/sequence-lsan.supp:print_suppressions=1
+        run: |
+          tests/test_sequencer_sequences
+          tests/test_sequencer_oom
+          tests/test_sequencer_concurrency
+
+  thread:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.13'
+      - name: Install header-generation dependency
+        run: pip install numpy
+      - name: Build the concurrency test with ThreadSanitizer
+        run: >-
+          make tests/test_sequencer_concurrency
+          CFLAGS="-O1 -g -Wall -Wextra -Wno-unused-parameter
+          -Wno-strict-aliasing -Wno-float-conversion
+          -Wno-missing-declarations -Wpointer-arith -DAMY_WAVETABLE
+          -fsanitize=thread -fno-omit-frame-pointer"
+      - name: Run the concurrency test
+        env:
+          TSAN_OPTIONS: halt_on_error=1
+        run: tests/test_sequencer_concurrency

.gitignore

@@ -6,6 +6,9 @@ tests/tst
 tests/test_clock_wrap
 tests/test_sequencer_active
 tests/test_sequencer_bounds
+tests/test_sequencer_sequences
+tests/test_sequencer_oom
+tests/test_sequencer_concurrency
 tests/test_bus_config
 tests/test_patch_slots
 tests/test_synth_readout

Makefile

@@ -64,7 +64,7 @@ EMSCRIPTEN_OPTIONS = -s WASM=1 --bind \
 -s ASYNCIFY -s ASYNCIFY_STACK_SIZE=128000
 PYTHON = python3
 
-.PHONY: default all clean amy-module test ctest web deploy-web godot-api c-api check-c-api
+.PHONY: default all clean amy-module test ctest web deploy-web godot-api c-api check-c-api js-api-test
 
 default: $(TARGET)
 all: default
@@ -83,6 +83,9 @@ check-c-api:
 	$(PYTHON) scripts/gen_patches_js.py --check
 	$(PYTHON) scripts/gen_pcm_presets_js.py --check
 
+js-api-test:
+	node tests/test_js_api.js
+
 SOURCES += src/algorithms.c src/amy.c src/envelope.c src/examples.c src/parse.c \
 	src/filters.c src/oscillators.c src/pcm.c src/interp_partials.c src/custom.c \
 	src/delay.c src/log2_exp2.c src/patches.c src/transfer.c src/sequencer.c \
@@ -124,26 +127,46 @@ amy-message: $(OBJECTS) src/amy-message.o
 # Plain C tests for things the audio-rendering suite can't reach -- e.g. clock
 # rollovers 50 days out, which you can only hit by fast-forwarding the counters.
 CTESTS = tests/test_clock_wrap tests/test_sequencer_active tests/test_sequencer_bounds \
+	         tests/test_sequencer_sequences \
+	         tests/test_sequencer_oom \
+	         tests/test_sequencer_concurrency \
          tests/test_bus_config tests/test_patch_slots \
          tests/test_synth_readout tests/test_log2_lut tests/test_clone_on_grow \
          tests/test_timebase_reset tests/test_osc_free_on_release \
          tests/test_voice_osc_range tests/test_dist_coefs tests/test_dist_scope
 
 # Static pattern rules, so these win over the generic %.o: %.c above (which
 # would compile without -Isrc and fail to find amy.h).
-$(addsuffix .o,$(CTESTS)): %.o: %.c $(HEADERS) src/patches.h
+SEQUENCE_SPECIAL_TESTS = tests/test_sequencer_oom tests/test_sequencer_concurrency
+
+$(addsuffix .o,$(filter-out $(SEQUENCE_SPECIAL_TESTS),$(CTESTS))): %.o: %.c $(HEADERS) src/patches.h
 	$(CC) $(CFLAGS) -Isrc -c $< -o $@
 
-$(CTESTS): %: %.o $(OBJECTS)
+$(filter-out $(SEQUENCE_SPECIAL_TESTS),$(CTESTS)): %: %.o $(OBJECTS)
 	$(CC) $(CFLAGS) $(OBJECTS) $< -Wall $(LIBS) -o $@
 
+# Build only the sequencer and its OOM test with the test-only allocation hook;
+# every other test and every production target uses the ordinary object.
+tests/sequencer_testing_impl.o: src/sequencer.c $(HEADERS) src/patches.h
+	$(CC) $(CFLAGS) -DAMY_SEQUENCE_TESTING -c $< -o $@
+
+tests/test_sequencer_oom.o: tests/test_sequencer_oom.c $(HEADERS) src/patches.h
+	$(CC) $(CFLAGS) -DAMY_SEQUENCE_TESTING -Isrc -c $< -o $@
+
+tests/test_sequencer_concurrency.o: tests/test_sequencer_concurrency.c $(HEADERS) src/patches.h
+	$(CC) $(CFLAGS) -DAMY_SEQUENCE_TESTING -Isrc -c $< -o $@
+
+$(SEQUENCE_SPECIAL_TESTS): %: %.o tests/sequencer_testing_impl.o $(filter-out src/sequencer.o,$(OBJECTS))
+	$(CC) $(CFLAGS) $(filter-out src/sequencer.o,$(OBJECTS)) tests/sequencer_testing_impl.o $< -Wall $(LIBS) -o $@
+
 ctest: $(CTESTS)
 	@for t in $(CTESTS); do echo "== $$t"; ./$$t || exit 1; done
 
 amy-module: amy-example
 	${EXTRA_PIP_ENV} ${PYTHON} -m pip install -r requirements.txt; touch src/amy.c; ${EXTRA_PIP_ENV} ${PYTHON} -m pip install . --force-reinstall --no-deps; cd ..
 
 test: amy-module
+	${PYTHON} tests/test_sequence_api.py
 	${PYTHON} -m amy.test
 
 qtest: amy-module

README.md

@@ -35,6 +35,7 @@ AMY was built by [DAn Ellis](https://research.google/people/DanEllis/) and [Bria
  * [**Interactive AMY tutorial**](https://shorepine.github.io/amy/tutorial.html)
  * [**AMY API**](docs/api.md)
  * [**AMY Synthesizer Details**](docs/synth.md)
+ * [**AMY Reusable Sequences**](docs/sequencer-sequences.md)
  * [**Distortion in AMY**](docs/distortions.md)
  * [**AMY's MIDI specification**](docs/midi.md)
  * [**AMY in Arduino Getting Started**](docs/arduino.md)
@@ -171,6 +172,7 @@ It's good to understand what wire messages are but you don't need to construct t
  * [**Interactive AMY tutorial**](https://shorepine.github.io/amy/tutorial.html)
  * [**AMY API**](docs/api.md)
  * [**AMY Synthesizer Details**](docs/synth.md)
+ * [**AMY Reusable Sequences**](docs/sequencer-sequences.md)
  * [**Distortion in AMY**](docs/distortions.md)
  * [**AMY's MIDI specification**](docs/midi.md)
  * [**AMY in Arduino Getting Started**](docs/arduino.md)