test(processor): verify noise-floor estimation tie-break determinism#127
Merged
Conversation
Add three hermetic unit tests for the determinism tie-break in `estimateNoiseFloorAndThreshold`: order-independence of candidate set, truncation picks lowest-RMS, and boundary at threshold 0.20. Rename seed constants `roomToneCandidatePercent` → `floorSeedTopPercent` and `roomToneCandidateMinCount` → `floorSeedMinCount` for naming cohesion with the live noise-floor seed (retired room-tone-candidate election concept). Remove stale word from comment in output.go. Signed-off-by: Martin Wimpress <code@wimpress.io>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Adds hermetic unit tests for noise-floor tie-break determinism, renames two internal constants for naming cohesion, and removes a stale word from a comment. Pure test additions and cosmetic renames — no logic or production code behavior changes.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three hermetic unit tests for the determinism tie-break in
estimateNoiseFloorAndThreshold: order-independence of candidateset, truncation picks lowest-RMS, and boundary at threshold 0.20.
Rename seed constants
roomToneCandidatePercent→floorSeedTopPercentand
roomToneCandidateMinCount→floorSeedMinCountfor namingcohesion with the live noise-floor seed (retired room-tone-candidate
election concept). Remove stale word from comment in output.go.