Check if qgroup exists before attempting to destroy it#484
Merged
mtwebster merged 1 commit intolinuxmint:masterfrom Dec 4, 2025
Merged
Check if qgroup exists before attempting to destroy it#484mtwebster merged 1 commit intolinuxmint:masterfrom
mtwebster merged 1 commit intolinuxmint:masterfrom
Conversation
When a btrfs subvolume is deleted, its associated qgroup is often automatically destroyed by btrfs. Timeshift would then attempt to explicitly destroy the qgroup and fail with an error message, even though the operation was successful. This change checks if the qgroup still exists before attempting to destroy it, eliminating the spurious error message. If the qgroup is already gone (auto-destroyed with the subvolume), we log a debug message instead. If the qgroup still exists, we attempt to destroy it and handle any race condition gracefully. Fixes the "Failed to destroy qgroup" error that occurs during snapshot deletion when quotas are enabled. Related: linuxmint#354, linuxmint#437
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a btrfs subvolume is deleted, its associated qgroup is often automatically destroyed by btrfs. Timeshift would then attempt to explicitly destroy the qgroup and fail with an error message like:
This happened because btrfs auto-destroys qgroups when their associated subvolumes are deleted. The previous fix in #458 made this non-fatal by returning
trueinstead offalse, but the error message was still printed, causing confusion.Fix
This change checks if the qgroup still exists (using
btrfs qgroup show) before attempting to destroy it:Testing
Tested on Manjaro Linux with btrfs quotas enabled:
E: Failed to destroy qgroup: '0/XXX'printed on every snapshot deletionRelated Issues