You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR looks good, but it reminded me that we should move away from passing lsiobase/alpine or lsiodev/blah as the IMAGE value to the ci container. This is something we'll have to change in the jenkins builder, but we also need to make the ci container ready for it.
We also have a draft PR: linuxserver/docker-jenkins-builder#183 which would move everything from lsiobase, lsiodev and lspipepr orgs on docker hub to the main linuxserver org, and the image names will be consistent with the ghcr naming scheme (ie. linuxserver/baseimage-alpine, linuxserver/lsiodev-blah and linuxserver/lspipepr-blah).
We prepared that PR when docker hub initiated pull limits and our ci builds were failing, but we were able to solve the issue another way. So the PR is still pending, but with a lower priority.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make url for
baseimagehttps://gilbnlsio2.s3.us-east-1.amazonaws.com/lsiobase/ubuntu/noble-566a4560-ls19/index.html
https://ci-tests.linuxserver.io/lsiobase/ubuntu/noble-566a4560-ls19/index.html