Repository navigation
add channels-dvr.subdomain.conf.sample - #818
Open
kris-anderson wants to merge 1 commit into
Open
kris-anderson wants to merge 1 commit into
kris-anderson wants to merge 1 commit into
Conversation
Channels DVR treats any request carrying X-Forwarded-For as remote and answers with its authorization-code page, so the sample documents that and offers Channels' own X-DVR-SkipAuth header, commented out, for LAN-only swag installs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
channels-dvr.subdomain.conf.samplefor Channels DVR Server (fancybits/channels-dvr, web UI on port 8089). The sample follows_template.subdomain.conf.sample. Its header uses the same bridge-mode / host-mode notes as the plex sample, because the Channels DVR docker instructions use--net=host.It differs from a plain template conf in one way, and only as a commented-out line:
X-Forwarded-Forheader as coming from outside the home network, whatever address the header holds.proxy.confalways sets that header, so through swag the web UI always shows Channels' "Unauthorized — Get Authorization Code" page (HTTP 403). The visitor then authorizes with their Channels account.proxy_set_header X-DVR-SkipAuth true;. That is Channels DVR's own header for skipping the check. The header comment and the line's comment both warn not to enable it on an internet-facing swag.Benefits of this PR and context
There is no Channels DVR sample yet. The obvious attempt doesn't work: clearing the header with
proxy_set_header X-Forwarded-For "";afterinclude /config/nginx/proxy.conf;changes nothing, because nginx sendsproxy.conf's own entry anyway. Users then hit an authorization page on their own network with no hint why. This sample documents the behaviour and both ways to use it.How Has This Been Tested?
fancybits/channels-dvr:tve), with swag only reachable from the LAN.X-Forwarded-For: 200X-Forwarded-Forwith any address (LAN, loopback or docker range): 403, the authorization code pageX-Forwarded-For+X-DVR-SkipAuth: true(or1): 200X-DVR-SkipAuthline enabled: 200 for/,/dvr,/devicesand/manifest.jsoncheck_samples.ymlsteps were run locally:nginx -tinghcr.io/linuxserver/nginxwith all samples and the currentproxy.conf.samplefrom docker-swag master:test is successful, both as shipped and with theX-DVR-SkipAuthline uncommentedSource / References
🤖 Generated with Claude Code