feat: ADK Enhancements & Explain Plain support #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ExplainOptions and ExplainFormat to core.rst API reference. Add explain() method to SQLFactory methods in builder.rst.
…ing tests - Updated ADK migration script to create memory tables if enabled in the config. - Added functions to dynamically retrieve memory store classes and check if memory migration is enabled. - Enhanced the `up` and `down` migration methods to handle memory tables. - Introduced comprehensive integration tests for storage backend URL signing with real cloud services (MinIO). - Added unit tests for storage backend URL signing API, covering various edge cases and unsupported protocols. - Improved protocols for cursor and connection operations, ensuring proper async support.
- Removed unnecessary checks for `extension_config` in ADK migration. - Simplified configuration retrieval in ADK store classes. - Enhanced observability span management by directly accessing attributes. - Introduced new type guards for various protocols to improve type safety. - Updated logging to utilize structured logging with type casting. - Improved error handling in storage operations by refining error checks. - Added support for async operations in storage pipeline with type guards. - Cleaned up migration command configurations to ensure type consistency. - Enhanced tests for storage signing protocols with type casting for clarity.
…guration handling
- Introduced several new protocols including HasAddListenerProtocol, HasArrowStoreProtocol, HasErrorsProtocol, HasNameProtocol, HasNotifiesProtocol, HasRowcountProtocol, HasSqlStateProtocol, HasSqliteErrorProtocol, HasValueProtocol, and HasTypeCodeProtocol. - Updated existing protocols to improve type safety and functionality. - Enhanced ReadableProtocol to accept an optional size parameter for the read method. refactor(storage): simplify row count handling in SyncStoragePipeline - Removed unnecessary checks for has_arrow_table_stats when determining row counts in SyncStoragePipeline methods. - Streamlined the logic for processing rows in both synchronous and asynchronous storage pipelines. fix(module_loader): improve import_string error handling - Refined the import_string function to handle attribute access more gracefully, reducing the likelihood of unhandled exceptions. refactor(schema): optimize type checking and field access - Improved type guards for dataclass and attrs instances, enhancing performance and readability. - Simplified field access logic in extract_dataclass_fields and related functions. test(adk): add integration tests for AioSQLite and SQLite memory stores - Implemented comprehensive tests for memory store operations including insert, search, delete by session, and delete older than. - Ensured that memory records are correctly handled and deduplicated. test(unit): add unit tests for ADK memory converters - Created tests for event and session conversion functions to validate correct behavior and output. chore(tests): remove redundant has_attr tests - Eliminated outdated tests for has_attr function, focusing on more relevant type guard tests.
…ype hints across driver implementations
…cols for Oracle and Psycopg
- Renamed and reorganized type handling modules for clarity and consistency. - Updated imports in Spanner, SQLite, and AsyncPG adapters to use the new _type_converter module. - Removed deprecated SpannerTypeConverter and replaced it with SpannerOutputConverter. - Introduced new type conversion logic in SQLite for JSON handling. - Updated tests to reflect changes in type converter usage across various adapters. - Ensured that UUID and JSON conversions are handled correctly in Spanner and DuckDB. - Added recursive conversion for NumPy arrays in schema utilities.
- Moved JSON adapter and converter functions to a new module `type_converter.py` for better organization. - Updated import paths in SQLite adapter and core modules to reflect the new structure. - Removed the old `_type_converter.py` file and consolidated its functionality into `type_converter.py`. - Adjusted unit tests across various adapters to use the new import paths for type converters. - Ensured compatibility with existing functionality while improving code maintainability.
- Updated imports in ADBC, Aiosqlite, Asyncmy, Asyncpg, BigQuery, DuckDB, Oracledb, Psqlpy, Psycopg, and SQLite adapters to reference the new _typing module instead of _types. - Introduced _typing.py files in each adapter to define type aliases for connection types, improving type hinting and compatibility with type checkers. - Removed the deprecated core type conversion module. - Adjusted the CommonDriverAttributesMixin to allow optional statement configuration. - Added a new Spanner adapter with appropriate type definitions and configurations. - Updated unit tests to reflect changes in type imports for Oracledb adapter.
…tions and health check parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upanddownmigration methods to handle memory tables.