fix: content corrections across liveblocks + yjs skills#2
Open
aribn wants to merge 1 commit intoliveblocks:mainfrom
Open
fix: content corrections across liveblocks + yjs skills#2aribn wants to merge 1 commit intoliveblocks:mainfrom
aribn wants to merge 1 commit intoliveblocks:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for publishing these skills! Looking forward to putting them to good use. While reading through, I came across a handful of small issues in the examples and prose worth flagging. All fixes verified against current
main. Happy to split this up or drop anything you'd rather handle differently.A few things that would trip up agents copying examples verbatim
liveblocks-best-practices/SKILL.md: the index entry readsprimitive-components-parts(plural), but the file on disk isprimitive-component-parts.md(singular). An agent following the index would hit a file-not-found.suspense-vs-regular-hooks.md: two import lines use@/liveblocks/reactwith a stray leading slash. The rest of the file already uses the correct@liveblocks/react.handling-connection-errors.md: theOther errorsswitch example declaresconst { roomId, threadId }across ~10 sibling cases without block scoping. Because allcaseclauses share one lexical scope, repeating those bindings throwsSyntaxError: Identifier 'roomId' has already been declaredat parse time.ROOM_CONNECTION_ERRORalready has the right pattern with{ }, so I applied the same shape to the rest.A couple of markdown links that don't render
suspense-vs-regular-hooks.md: two instances of[`useThreads`][https://…](reference-style link with a URL literal instead of a label — renders as plain text), plus one empty shortcut[`ClientSideSuspense`][]with no matching reference definition. Swapped both for the inline[text](url)form.One small math thing
smoother-realtime-updates.md: "The minimum value is16, once every 10ms, 60FPS." Since 1000 / 16 ≈ 62.5, the16and60FPSare both right — just the "10ms" in the middle that's inconsistent. Changed to "once every 16ms".Typos I noticed while reading through
liveblocks-best-practices/SKILL.md:extgensions,losing losing, missing:after`prevent-unsaved-changes-being-lost`,multiplayer,commenting,pdates, and one lowercase sentence startai-as-a-collaborator.md:colalboratoryjs-best-practices/SKILL.md:lazy laodedsmoother-realtime-updates.md:rooms will lotsHappy to split the correctness fixes from the typo cleanup into separate PRs if that's cleaner.