-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: prevent VAD from driving user_state when turn_detection=sst #5582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MdSadiqMd
wants to merge
13
commits into
livekit:main
Choose a base branch
from
MdSadiqMd:fix/prevent-vad-from-driving-userstate
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ffa20d2
fix: prevent VAD from driving user_state when turn_detection=sst
MdSadiqMd a9be27f
feat(voice): add user_state_source to decouple VAD from user_state
MdSadiqMd e73c3c2
fixing stt user state
MdSadiqMd fac4cfd
added vsd validation
MdSadiqMd 6ab28a1
added vsd validation
MdSadiqMd 196b90d
fix: STT EOS never triggers EOU when user_state_source=stt
MdSadiqMd 630afd7
fix: some vad stuff fix, and removing the event overlap
MdSadiqMd 243c471
fix: stt start of speech cancels vsd end of turn
MdSadiqMd 3ffb924
bug: vad cleanup should honor the force argument
MdSadiqMd 7fbf60e
revert back
MdSadiqMd f17425d
fix: force user_state reset when audio input is disabled
MdSadiqMd 2dd29bb
feat: Added on_stt_speech_started() / on_stt_speech_ended() to Recogn…
MdSadiqMd a7e3bd8
fix: on_stt_speech_ended missing _user_silence_event.set()
MdSadiqMd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.